From: Christoph Hellwig <hch@lst.de>
To: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] sanitize xfs_initialize_vnode
Date: Thu, 24 Jul 2008 08:20:02 +0200 [thread overview]
Message-ID: <20080724062002.GA26938@lst.de> (raw)
In-Reply-To: <20080724061615.GR6761@disturbed>
On Thu, Jul 24, 2008 at 04:16:15PM +1000, Dave Chinner wrote:
> > + }
> > +
> > + xfs_iflags_clear(ip, XFS_INEW);
> > + barrier();
> > +
> > + unlock_new_inode(inode);
> > +}
>
> Do we still need that barrier()? Or has the reason for it
> existing been lost in the mists of time? Regardless, it was
> there before so this is not a reason to stop the patch from
> going in...
Good question. I wonder why it's there in the first place.
next prev parent reply other threads:[~2008-07-24 6:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 10:52 [PATCH] sanitize xfs_initialize_vnode Christoph Hellwig
2008-05-20 6:36 ` Christoph Hellwig
2008-06-27 13:05 ` Christoph Hellwig
2008-07-23 8:06 ` Christoph Hellwig
2008-05-21 8:21 ` Christoph Hellwig
2008-07-23 19:51 ` Christoph Hellwig
2008-07-24 6:16 ` Dave Chinner
2008-07-24 6:20 ` Christoph Hellwig [this message]
2008-07-28 22:57 ` Christoph Hellwig
2008-07-29 1:02 ` Niv Sardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724062002.GA26938@lst.de \
--to=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.