All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
	denys@visp.net.lb, netdev@vger.kernel.org
Subject: Re: [PATCH] Re: SFQ depth limit
Date: Thu, 24 Jul 2008 09:49:08 +0000	[thread overview]
Message-ID: <20080724094908.GA3946@ff.dom.local> (raw)
In-Reply-To: <48884133.8070301@trash.net>

On Thu, Jul 24, 2008 at 10:45:39AM +0200, Patrick McHardy wrote:
> David Miller wrote:
>> From: Jarek Poplawski <jarkao2@gmail.com>
>> Date: Sun, 29 Jun 2008 21:11:13 +0200
>>
>>   
>>> sch_sfq: dump a real number of flows
>>>
>>> Dump the "flows" number according to the number of active flows
>>> instead of repeating the "limit".
>>>     
>>
>> Looks reasonable, applied, thanks Jarek.
>
> I'm not sure we should do this, this removes the symetry between
> ->init/change and ->dump. Its not a big deal in this case since
> flows is unused in ->init anyway, but still its a not so nice
> precedent. Such things should normally be put in the statistics.
>

Hmm... I didn't even notice this. But I guess, this patch didn't
introduce this precedent since this non-config "flow" was dumped
before. Btw., I can see e.g. direct_pkts in htb_dump() which looks
like similar precedent. IMHO, printing the same thing 2x under
different names is worse precedent. Anyway, this patch isn't any
big deal, so I can send a revert.

Thanks,
Jarek P.

  reply	other threads:[~2008-07-24  9:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-28 19:02 SFQ depth limit Denys Fedoryshchenko
2008-06-29 19:11 ` [PATCH] " Jarek Poplawski
2008-06-29 19:38   ` Denys Fedoryshchenko
2008-07-24  4:34   ` David Miller
2008-07-24  8:45     ` Patrick McHardy
2008-07-24  9:49       ` Jarek Poplawski [this message]
2008-07-24  9:57         ` Patrick McHardy
2008-07-24 10:53           ` [PATCH] pkt_sched: sch_sfq: revert "dump a real number of flows" patch Jarek Poplawski
2008-07-26  9:29             ` David Miller
2008-07-26 10:58               ` Jarek Poplawski
2008-07-27  0:24                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080724094908.GA3946@ff.dom.local \
    --to=jarkao2@gmail.com \
    --cc=davem@davemloft.net \
    --cc=denys@visp.net.lb \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.