From: agk@sourceware.org <agk@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/tools pvcreate.c pvremove.c
Date: 24 Jul 2008 15:25:10 -0000 [thread overview]
Message-ID: <20080724152510.7361.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: agk at sourceware.org 2008-07-24 15:25:10
Modified files:
tools : pvcreate.c pvremove.c
Log message:
reinstate lost FIXME
- only if kernel gives the info, not to be worked out in userspace
- with lvm.conf option to enable/disable the check
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvcreate.c.diff?cvsroot=lvm2&r1=1.67&r2=1.68
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.22&r2=1.23
--- LVM2/tools/pvcreate.c 2008/07/23 19:46:33 1.67
+++ LVM2/tools/pvcreate.c 2008/07/24 15:25:09 1.68
@@ -37,6 +37,8 @@
struct device *dev;
uint64_t md_superblock;
+ /* FIXME Check partition type is LVM unless --force is given */
+
/* Is there a pv here already? */
/* FIXME Use partial mode here? */
pv = pv_read(cmd, name, NULL, NULL, 0);
--- LVM2/tools/pvremove.c 2008/07/23 19:46:33 1.22
+++ LVM2/tools/pvremove.c 2008/07/24 15:25:09 1.23
@@ -26,6 +26,8 @@
{
struct physical_volume *pv;
+ /* FIXME Check partition type is LVM unless --force is given */
+
/* Is there a pv here already? */
/* If not, this is an error unless you used -f. */
if (!(pv = pv_read(cmd, name, NULL, NULL, 1))) {
next reply other threads:[~2008-07-24 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 15:25 agk [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-11-22 1:25 LVM2/tools pvcreate.c pvremove.c agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724152510.7361.qmail@sourceware.org \
--to=agk@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.