Re: [PATCH {1,3}/7] ata: add missing ATA_CMD_* defines

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Thursday 24 July 2008, Chris Wedgwood wrote:
> On Wed, Jul 23, 2008 at 08:40:18PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 
> > Add missing ATA_CMD_* defines to <linux/ata.h>.  Also add
> > ATA_EXABYTE_ENABLE_NEST, SETFEATURES_AAM_* and ATA_SMART_*
> > defines while at it.
> >
> > Partially based on earlier work by Chris Wedgwood.
> 
> [...]
> 
> 
> On Wed, Jul 23, 2008 at 08:42:45PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > * Use ATA_CMD_* defines instead of WIN_* ones.
> >
> > While at it:
> >
> > * EXABYTE_ENABLE_NEXT -> ATA_EXABYTE_ENABLE_NEST
> >
> > * SETFEATURES_{EN,DIS}_WCACHE -> SETFEATURES_WC_{ON,OFF}
> >
> > * SETFEATURES_{EN,DIS}_AAM -> SETFEATURES_AAM_{ON,OFF}
> >
> > * SMART_* -> ATA_SMART_*
> >
> > * Remove stale comment from ide-proc.c.
> >
> > Partially based on earlier work by Chris Wedgwood.
> 
> ACK/signoff from me (in so far as it's relevant, my original patches
> are so old I'm sure Bart probably had to so it almost all again).

Thanks, added your ACK to #1/#3 and Jeff's to #1/#2.