All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] remove <linux/hdreg.h>
Date: Thu, 24 Jul 2008 22:11:52 +0200	[thread overview]
Message-ID: <200807242211.53655.bzolnier@gmail.com> (raw)
In-Reply-To: <20080724194915.GA23998@infradead.org>

On Thursday 24 July 2008, Christoph Hellwig wrote:
> On Thu, Jul 24, 2008 at 09:37:58PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > It has no in-kernel users now and can be removed.
> 
> But beeing an exported header it has userspace users.  Plese keep it
> and just leave the ioctl defintions as need by userspace in it instead
> of renaming that part to hdio_ioctls.h.

Agreed w.r.t. to keeping it (the last patch was more of rfc than intended
to be commited, sorry that I didn't mark it as such) but what's wrong with
moving ioctl definitions to hdio_ioctls.h so we have clean separation of
obsoleted userspace-only stuff & userspace/kernel stuff?

[ The hdio_ioctls.h include is also exported to userspace and included
  by hdreg.h internally (patch #1) so userspace should be unaffected. ]

Thanks,
Bart

  reply	other threads:[~2008-07-24 20:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24 19:37 [PATCH 4/4] remove <linux/hdreg.h> Bartlomiej Zolnierkiewicz
2008-07-24 19:49 ` Christoph Hellwig
2008-07-24 20:11   ` Bartlomiej Zolnierkiewicz [this message]
2008-07-24 20:22     ` Christoph Hellwig
2008-07-27 15:28       ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807242211.53655.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.