From: Thomas Graf <tgraf@suug.ch>
To: Julius Volz <juliusv@google.com>
Cc: netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
horms@verge.net.au, kaber@trash.net, davem@davemloft.net,
vbusam@google.com
Subject: Re: [PATCHv2 2/2] IPVS: Add genetlink interface implementation
Date: Fri, 25 Jul 2008 01:58:33 +0200 [thread overview]
Message-ID: <20080724235833.GD20815@postel.suug.ch> (raw)
In-Reply-To: <1216645375-20410-3-git-send-email-juliusv@google.com>
* Julius Volz <juliusv@google.com> 2008-07-21 15:02
> +static int ip_vs_genl_parse_dest(struct ip_vs_dest_user *udest,
> + struct nlattr *nla, int full_entry)
> +{
> + struct nlattr *attrs[IPVS_SVC_ATTR_MAX + 1];
> + struct nlattr *nla_addr, *nla_port;
> +
> + /* Parse mandatory identifying destination fields first */
> + if (nla == NULL ||
> + nla_parse_nested(attrs, IPVS_DEST_ATTR_MAX, nla, ip_vs_dest_policy))
Small typo here, attrs[] is defined with a length of IPVS_SVC_ATTR_MAX+1
while IPVS_DEST_ATTR_MAX is passed to to nla_parse_nested.
next prev parent reply other threads:[~2008-07-24 23:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 13:02 [PATCHv2 0/2] IPVS: Add Generic Netlink configuration interface Julius Volz
2008-07-21 13:02 ` [PATCHv2 1/2] IPVS: Add genetlink interface definitions to ip_vs.h Julius Volz
2008-07-21 13:02 ` [PATCHv2 2/2] IPVS: Add genetlink interface implementation Julius Volz
2008-07-24 23:58 ` Thomas Graf [this message]
2008-07-25 22:39 ` Julius Volz
2008-07-22 0:34 ` [PATCHv2 0/2] IPVS: Add Generic Netlink configuration interface Simon Horman
2008-07-22 16:43 ` Julius Volz
2008-07-22 22:59 ` Vince Busam
2008-07-23 21:39 ` Vince Busam
2008-07-25 5:58 ` Simon Horman
2008-07-25 22:36 ` Julius Volz
2008-07-25 23:29 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724235833.GD20815@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=juliusv@google.com \
--cc=kaber@trash.net \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vbusam@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.