From: Andrew Morton <akpm@linux-foundation.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Andrea Righi <righi.andrea@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: PAGE_ALIGN() compile breakage
Date: Fri, 25 Jul 2008 02:25:47 -0700 [thread overview]
Message-ID: <20080725022547.a05ea755.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080725091455.GD19310@cs181140183.pp.htv.fi>
On Fri, 25 Jul 2008 12:14:55 +0300 Adrian Bunk <bunk@kernel.org> wrote:
> Ideally, all headers should be self-contained. IOW, they should #include
> everything they use.
Yup. And the core reason for our headers mess is that the headers do
too much stuff, and cnosequently demand a large dependency trail.
> But TASK_UNMAPPED_BASE in asm/processor.h on some architectures uses
> PAGE_ALIGN() that got moved from asm/page.h to linux/mm.h .
Probably mm.h should be split up - put the simple things (usually
declarations) into one "early" header file and leave the more
heavyweight things (usually implementations) in mm.h.
next prev parent reply other threads:[~2008-07-25 9:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 8:39 PAGE_ALIGN() compile breakage Adrian Bunk
2008-07-25 8:55 ` Andrew Morton
2008-07-25 9:14 ` Adrian Bunk
2008-07-25 9:25 ` Andrew Morton [this message]
2008-07-25 18:34 ` Andrea Righi
2008-07-25 9:27 ` Adrian Bunk
2008-07-25 9:34 ` Andrew Morton
2008-07-25 12:24 ` __weak vs ifdef Matthew Wilcox
2008-07-25 12:41 ` Andrew Morton
2008-07-26 19:38 ` Linus Torvalds
2010-02-18 2:07 ` Grant Likely
2010-02-18 2:22 ` Linus Torvalds
2008-07-26 21:22 ` [-mm patch] mm/util.c must #include <linux/sched.h> Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725022547.a05ea755.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=righi.andrea@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.