From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Niv Sardi-Altivanik <xaiki@sgi.com>,
sgi.bugs.xfs@engr.sgi.com, xfs@oss.sgi.com
Subject: Re: TAKE 981498 - remove mounpoint UUID code
Date: Fri, 25 Jul 2008 15:01:49 +1000 [thread overview]
Message-ID: <20080725050149.GL5947@disturbed> (raw)
In-Reply-To: <48894C66.5060204@sandeen.net>
On Thu, Jul 24, 2008 at 10:45:42PM -0500, Eric Sandeen wrote:
> Niv Sardi-Altivanik wrote:
> > remove mounpoint UUID code
>
> Are you sure this didn't change any disk structures? The patch I sent
> was RFC and completely untested... (and disclosed as such...) :)
Looking at the original patch, it definitely does change the format
of log structures on disk. it removes the union of the uuid and rdev
in the xfs_inode_log_format[32|64] which takes that entry from 16
bytes down to 4 bytes. So I'd suggest that thisss should be removed
immediately before it hits public and people start corrupting their
filesystems....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-07-25 5:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 3:38 TAKE 981498 - remove mounpoint UUID code Niv Sardi-Altivanik
2008-07-25 3:45 ` Eric Sandeen
2008-07-25 5:01 ` Dave Chinner [this message]
2008-07-25 15:01 ` Eric Sandeen
2008-07-28 1:06 ` Lachlan McIlroy
2008-07-28 1:56 ` Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725050149.GL5947@disturbed \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xaiki@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.