From: Russell King <rmk@arm.linux.org.uk>
To: Laurent Pinchart <laurentp@cse-semaphore.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-serial@vger.kernel.org
Subject: Re: [PATCH] Fix oops in the 8250 serial driver when accessing a removed device
Date: Fri, 25 Jul 2008 10:51:29 +0100 [thread overview]
Message-ID: <20080725095128.GC21452@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200807221831.54473.laurentp@cse-semaphore.com>
On Tue, Jul 22, 2008 at 06:31:50PM +0200, Laurent Pinchart wrote:
> Hi Russell,
>
> On Tuesday 22 July 2008, Alan Cox wrote:
> > > When a plug-and-play 8250 device is detected, the driver reuses one of the
> > > dummy ports. If that device is later removed, the port goes pack to the
> > > dummy ports pool. The capabilities field is not reset, which causes a oops
> > > when trying to access the port.
> >
> > Some day we need to allocate new dummy ports so there is always one free.
> >
> > > This patch resets the capabilities field when a 8250 device is
> > > unregistered.
> >
> > Looks good to me. Would appreciate Russell's view though.
>
> Could you please review the patch (available at http://marc.info/?l=linux-serial&m=121674107306179&w=2) ?
> I'd like it to go into 2.6.27 if possible.
Is there a link to the oops as well?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-07-25 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 15:37 [PATCH] Fix oops in the 8250 serial driver when accessing a removed device Laurent Pinchart
2008-07-22 15:54 ` Alan Cox
2008-07-22 16:31 ` Laurent Pinchart
2008-07-25 9:51 ` Russell King [this message]
2008-07-25 11:40 ` Laurent Pinchart
2008-07-25 11:57 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725095128.GC21452@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=laurentp@cse-semaphore.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.