All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Ulrich Drepper <drepper@redhat.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	akpm@linux-foundation.org, davidel@xmailserver.org,
	mtk.manpages@gmail.com, torvalds@linux-foundation.org
Subject: [patch] signalfd: fix undefined reference to `compat_sys_signalfd4'
Date: Fri, 25 Jul 2008 13:06:16 +0200	[thread overview]
Message-ID: <20080725110616.GA29447@elte.hu> (raw)
In-Reply-To: <200805062118.m46LI7hn004047@devserv.devel.redhat.com>


* Ulrich Drepper <drepper@redhat.com> wrote:

> This patch adds the new signalfd4 syscall.  It extends the old 
> signalfd syscall by one parameter which is meant to hold a flag value.  
> In this patch the only flag support is SFD_CLOEXEC which causes the 
> close-on-exec flag for the returned file descriptor to be set.

this patch causes the following build failure on !CONFIG_SIGNALFD:

 arch/x86/ia32/built-in.o: In function `ia32_sys_call_table':
 (.rodata+0xa38): undefined reference to `compat_sys_signalfd4'
 make: *** [.tmp_vmlinux1] Error 1

tested fix below.

	Ingo

-------------->
>From 72dc5d608422e80ad5e1aac2d7b9bd16b7dbc6e0 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Fri, 25 Jul 2008 13:02:37 +0200
Subject: [PATCH] signalfd: fix undefined reference to `compat_sys_signalfd4'

fix:

arch/x86/ia32/built-in.o: In function `ia32_sys_call_table':
(.rodata+0xa38): undefined reference to `compat_sys_signalfd4'

on !CONFIG_SIGNALFD.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/sys_ni.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
index 55eca15..08d6e1b 100644
--- a/kernel/sys_ni.c
+++ b/kernel/sys_ni.c
@@ -160,6 +160,7 @@ cond_syscall(sys_ioprio_get);
 cond_syscall(sys_signalfd);
 cond_syscall(sys_signalfd4);
 cond_syscall(compat_sys_signalfd);
+cond_syscall(compat_sys_signalfd4);
 cond_syscall(sys_timerfd_create);
 cond_syscall(sys_timerfd_settime);
 cond_syscall(sys_timerfd_gettime);

      reply	other threads:[~2008-07-25 11:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-06 21:18 [PATCH 04/18] flag parameters: signalfd Ulrich Drepper
2008-07-25 11:06 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080725110616.GA29447@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=davidel@xmailserver.org \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.