All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Yu Zhiguo <yuzg@cn.fujitsu.com>
Cc: audit-list <linux-audit@redhat.com>
Subject: Re: [PATCH] fix a bug that option '-i' cannot be used
Date: Fri, 25 Jul 2008 14:22:48 -0400	[thread overview]
Message-ID: <200807251422.49483.sgrubb@redhat.com> (raw)
In-Reply-To: <48816289.4060500@cn.fujitsu.com>

Hello Yu,

On Friday 18 July 2008 23:42:01 Yu Zhiguo wrote:
>   Option '-i' cannot be used, because the check about option '-R'
> in main() is wrong.
>   When check option '-R', we should consider whether option '-i'
> is specified.

I was just looking at this patch. The intention with the -R option is for it 
to be given saying that all options will be read from the file. You should be 
able to place "-i" on a line by itself within the file and it should ignore 
errors. This would be similar to the way the -D option is given by itself 
near the top of a typical rule file.

I agree with some of the cleanup that this patch suggests and will apply that 
part. But I think the intent was for "-i" to be in the file and not the 
command line.

Thanks,
-Steve

  parent reply	other threads:[~2008-07-25 18:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-19  3:42 [PATCH] fix a bug that option '-i' cannot be used Yu Zhiguo
2008-07-23  0:53 ` Yu Zhiguo
2008-07-25 18:22 ` Steve Grubb [this message]
2008-07-26  2:48   ` Yu Zhiguo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807251422.49483.sgrubb@redhat.com \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=yuzg@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.