From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KMU3u-00018Q-HN for mharc-grub-devel@gnu.org; Fri, 25 Jul 2008 16:38:50 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KMU3s-00018H-6Y for grub-devel@gnu.org; Fri, 25 Jul 2008 16:38:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KMU3q-00017r-PB for grub-devel@gnu.org; Fri, 25 Jul 2008 16:38:47 -0400 Received: from [199.232.76.173] (port=37596 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KMU3q-00017n-LV for grub-devel@gnu.org; Fri, 25 Jul 2008 16:38:46 -0400 Received: from aybabtu.com ([69.60.117.155]:33361) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KMU3q-0008Vt-8G for grub-devel@gnu.org; Fri, 25 Jul 2008 16:38:46 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KMTxe-0005SX-Jv for grub-devel@gnu.org; Fri, 25 Jul 2008 22:32:22 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KMU2x-0004or-E5 for grub-devel@gnu.org; Fri, 25 Jul 2008 22:37:51 +0200 Date: Fri, 25 Jul 2008 22:37:51 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080725203751.GC18149@thorin> References: <4888158C.1070506@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4888158C.1070506@t-online.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Abort grub-install if prefix cannot be determined X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2008 20:38:48 -0000 On Thu, Jul 24, 2008 at 07:39:24AM +0200, Christian Franke wrote: > grub-install does not check error return from > make_system_path_relative_to_its_root() fails. > > BTW: Unlike the other scripts, grub-install does not 'set -e'. Is this > intentional or historic ?-) I think it's historic. Wouldn't mind moving it to 'set -e' (although one would have to check which grub-probe calls are allowed to fail). What do others think? -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)