From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KMU8I-0003Ar-SU for mharc-grub-devel@gnu.org; Fri, 25 Jul 2008 16:43:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KMU8G-0003A7-R3 for grub-devel@gnu.org; Fri, 25 Jul 2008 16:43:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KMU8E-000397-Hn for grub-devel@gnu.org; Fri, 25 Jul 2008 16:43:19 -0400 Received: from [199.232.76.173] (port=46416 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KMU8E-000393-Dk for grub-devel@gnu.org; Fri, 25 Jul 2008 16:43:18 -0400 Received: from aybabtu.com ([69.60.117.155]:39364) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KMU8D-0000ma-Ud for grub-devel@gnu.org; Fri, 25 Jul 2008 16:43:18 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KMU21-0005Ss-SY for grub-devel@gnu.org; Fri, 25 Jul 2008 22:36:54 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KMU7K-0004sd-8m for grub-devel@gnu.org; Fri, 25 Jul 2008 22:42:22 +0200 Date: Fri, 25 Jul 2008 22:42:22 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080725204222.GE18149@thorin> References: <4888E3C5.9090707@t-online.de> <4888E868.10404@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4888E868.10404@t-online.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] update-grub for Cygwin X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2008 20:43:21 -0000 On Thu, Jul 24, 2008 at 10:39:04PM +0200, Christian Franke wrote: > + > +d="`${grub_probe} -t drive "$p" 2>/dev/null`" || exit 0 Please avoid reliing on '-t drive'. It's based on device.map which just contains guesswork. prepare_grub_to_access_device() is a much better option. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)