From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] stop using file_update_time
Date: Sat, 26 Jul 2008 19:13:48 +1000 [thread overview]
Message-ID: <20080726091348.GT5947@disturbed> (raw)
In-Reply-To: <20080726063339.GC22603@lst.de>
On Sat, Jul 26, 2008 at 08:33:39AM +0200, Christoph Hellwig wrote:
> xfs_ichtime updates the xfs_inode and Linux inode timestamps just fine,
> no need to call file_update_time and then copy the values over to the
> XFS inode. The only additional thing in file_update_time are checks
> not applicable to the write path.
.....
> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_iops.h
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_iops.h 2008-07-24 08:37:09.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_iops.h 2008-07-24 08:37:40.000000000 +0200
> @@ -26,9 +26,6 @@ extern const struct file_operations xfs_
>
> extern ssize_t xfs_vn_listxattr(struct dentry *, char *data, size_t size);
>
> -extern void xfs_ichgtime(struct xfs_inode *, int);
> -extern void xfs_ichgtime_fast(struct xfs_inode *, struct inode *, int);
> -
I don't think you meant to remove the xfs_ichgtime() prototype
as well...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-07-26 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-26 6:33 [PATCH 3/3] stop using file_update_time Christoph Hellwig
2008-07-26 9:13 ` Dave Chinner [this message]
2008-07-26 9:14 ` Christoph Hellwig
2008-07-26 9:22 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080726091348.GT5947@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.