From: Ingo Molnar <mingo@elte.hu>
To: Robert Richter <robert.richter@amd.com>
Cc: Jason Yeh <jason.yeh@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
oprofile-list <oprofile-list@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Oprofile Multiplexing Patch
Date: Sat, 26 Jul 2008 13:16:26 +0200 [thread overview]
Message-ID: <20080726111626.GL25890@elte.hu> (raw)
In-Reply-To: <1216847153-28435-2-git-send-email-robert.richter@amd.com>
> From: Jason Yeh <jason.yeh@amd.com>
> diff --git a/arch/x86/oprofile/op_model_p4.c b/arch/x86/oprofile/op_model_p4.c
> index 56b4757..e641545 100644
> --- a/arch/x86/oprofile/op_model_p4.c
> +++ b/arch/x86/oprofile/op_model_p4.c
> @@ -701,6 +701,8 @@ static void p4_shutdown(struct op_msrs const * const msrs)
> struct op_x86_model_spec const op_p4_ht2_spec = {
> .num_counters = NUM_COUNTERS_HT2,
> .num_controls = NUM_CONTROLS_HT2,
> + .num_hardware_counters = NUM_COUNTERS_HT2,
> + .num_hardware_controls = NUM_CONTROLS_HT2,
is there any further change needed for Intel CPUs to benefit from
multiplexing too, up to the max of 32 controls? (AFAICS it should work
as-is, correct?)
Ingo
next prev parent reply other threads:[~2008-07-26 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 21:05 [PATCH] Oprofile Multiplexing Patch Robert Richter
2008-07-26 11:16 ` Ingo Molnar [this message]
2008-07-29 17:54 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080726111626.GL25890@elte.hu \
--to=mingo@elte.hu \
--cc=jason.yeh@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sourceforge.net \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.