From: Yinghai Lu <yhlu.kernel@gmail.com>
To: "Greg Kroah-Hartman" <gregkh@suse.de>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: don't hide bios bug warning
Date: Sat, 26 Jul 2008 18:12:15 -0700 [thread overview]
Message-ID: <200807261812.15836.yhlu.kernel@gmail.com> (raw)
quirk_usb_disable_handoff will wait a while if there is BIOS bug.
let the end user know the reason for that.
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
---
drivers/usb/host/pci-quirks.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
Index: linux-2.6/drivers/usb/host/pci-quirks.c
===================================================================
--- linux-2.6.orig/drivers/usb/host/pci-quirks.c
+++ linux-2.6/drivers/usb/host/pci-quirks.c
@@ -190,7 +190,8 @@ static void __devinit quirk_usb_handoff_
msleep(10);
}
if (wait_time <= 0)
- dev_warn(&pdev->dev, "OHCI: BIOS handoff failed"
+ dev_printk(KERN_WARNING, &pdev->dev,
+ "OHCI: BIOS handoff failed"
" (BIOS bug?) %08x\n",
readl(base + OHCI_CONTROL));
@@ -242,7 +243,8 @@ static void __devinit quirk_usb_disable_
switch (cap & 0xff) {
case 1: /* BIOS/SMM/... handoff support */
if ((cap & EHCI_USBLEGSUP_BIOS)) {
- dev_dbg(&pdev->dev, "EHCI: BIOS handoff\n");
+ dev_printk(KERN_DEBUG, &pdev->dev,
+ "EHCI: BIOS handoff\n");
#if 0
/* aleksey_gorelov@phoenix.com reports that some systems need SMI forced on,
@@ -283,7 +285,8 @@ static void __devinit quirk_usb_disable_
/* well, possibly buggy BIOS... try to shut
* it down, and hope nothing goes too wrong
*/
- dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
+ dev_printk(KERN_WARNING, &pdev->dev,
+ "EHCI: BIOS handoff failed"
" (BIOS bug?) %08x\n", cap);
pci_write_config_byte(pdev, offset + 2, 0);
}
next reply other threads:[~2008-07-27 1:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 1:12 Yinghai Lu [this message]
2008-07-27 1:24 ` [PATCH] usb: don't hide bios bug warning Greg KH
2008-07-27 1:48 ` Yinghai Lu
2008-07-27 1:56 ` David Brownell
2008-07-27 3:24 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807261812.15836.yhlu.kernel@gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.