All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] update-grub for Cygwin
Date: Sun, 27 Jul 2008 14:39:46 +0200	[thread overview]
Message-ID: <20080727123946.GC11242@thorin> (raw)
In-Reply-To: <1217138942.16601.6.camel@ct>

On Sun, Jul 27, 2008 at 02:09:02AM -0400, Pavel Roskin wrote:
> On Sat, 2008-07-26 at 14:53 +0200, Christian Franke wrote:
> > Robert Millan wrote:
> > > On Thu, Jul 24, 2008 at 10:19:17PM +0200, Christian Franke wrote:
> > >   
> > >> +  case "`uname 2>/dev/null`" in
> > >> +    CYGWIN*)
> > >>     
> > >
> > > Could this be done at build time instead? (when generating update-grub
> > > from update-grub.in)
> > >
> > >   
> > 
> > Yes, of course. Some alternatives:
> ...
> 
> I think it's better to have the check at the run time than any of those
> alternatives.  If we have many OS specific checks, then we can think how
> to leave the relevant ones.  At this point, it's probably not worth the
> trouble.

Ok I don't mind.  It was just a suggestion.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)



  reply	other threads:[~2008-07-27 12:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24 20:19 [PATCH] update-grub for Cygwin Christian Franke
2008-07-24 20:39 ` Christian Franke
2008-07-25 20:42   ` Robert Millan
2008-07-31 21:32     ` Christian Franke
2008-08-04 19:46       ` Christian Franke
2008-08-04 20:00         ` Robert Millan
2008-08-04 20:40           ` Christian Franke
2008-08-04 21:41             ` Robert Millan
2008-08-05 12:13               ` Christian Franke
2008-08-05 20:09                 ` Robert Millan
2008-08-06 18:48                   ` Christian Franke
2008-07-25 20:40 ` Robert Millan
2008-07-26 12:53   ` Christian Franke
2008-07-27  6:09     ` Pavel Roskin
2008-07-27 12:39       ` Robert Millan [this message]
2008-07-29 15:40         ` Christian Franke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080727123946.GC11242@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.