From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 2.6.26-git] spi_s3c24xx: really assign busnum Date: Sun, 27 Jul 2008 19:44:34 -0700 Message-ID: <20080727194434.35b8f980.akpm@linux-foundation.org> References: <200807271540.05120.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Ben Dooks To: David Brownell Return-path: In-Reply-To: <200807271540.05120.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Sun, 27 Jul 2008 15:40:04 -0700 David Brownell wrote: > From: Ben Dooks > > The original "Pass the bus number we expect the S3C24XX SPI driver to attach > to via the platform data." [1] patch was mis-sent, and missed two important > parts of the diff, which was to actually set the bus_num field and add > the relevant field to the platform data. > um, OK. I'd consider that changelog to be partial, because it doesn't describe the consequences of the bug. It means that people who are scratching their heads over whether this should be in 2.6.26.x don't have enough info to go on. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/