Re: [patch 2.6.26-git] spi_s3c24xx: really assign busnum

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Sunday 27 July 2008, Andrew Morton wrote:
> On Sun, 27 Jul 2008 15:40:04 -0700 David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> wrote:
> 
> > From: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
> > 
> > The original "Pass the bus number we expect the S3C24XX SPI driver to attach
> > to via the platform data." [1]  patch was mis-sent, and missed two important
> > parts of the diff, which was to actually set the bus_num field and add
> > the relevant field to the platform data.
> > 
> 
> um, OK.  I'd consider that changelog to be partial, because it doesn't
> describe the consequences of the bug.

Consequences:  only bus number zero will ever be used by that SPI controller.


> It means that people who are scratching their heads over whether this
> should be in 2.6.26.x don't have enough info to go on.

I'd let Ben suggest that one.  This unfortunately sat in my queue for
a while before I noticed it... else it could have made 2.6.26-final.

- Dave


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/