From: Christoph Hellwig <hch@lst.de>
To: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 07/15] refactor xfs_btree_readahead
Date: Mon, 28 Jul 2008 17:39:59 +0200 [thread overview]
Message-ID: <20080728153959.GA29132@lst.de> (raw)
In-Reply-To: <20080724233655.GH15438@disturbed>
On Fri, Jul 25, 2008 at 09:36:55AM +1000, Dave Chinner wrote:
> I've been wondering if this is the best naming convention -
> appending a single s or l to indicate short or long btree ops.
> Perhaps this would be better as xfs_btree_readahead_short() and
> xfs_btree_readahead_long(), esp. as we dropped the 'core' from
> the caller to make it xfs_btree_readahead().
I've renamedthe helpers to xfs_btree_readahead_lblock /
xfs_btree_readahead_slblock to match the naming for the other short /
long block helpers.
next prev parent reply other threads:[~2008-07-28 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 20:08 [PATCH 07/15] refactor xfs_btree_readahead Christoph Hellwig
2008-07-24 23:36 ` Dave Chinner
2008-07-25 4:14 ` Christoph Hellwig
2008-07-28 15:39 ` Christoph Hellwig [this message]
2008-07-30 7:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080728153959.GA29132@lst.de \
--to=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.