All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: grub-probe fails to find PC partition due to Apple disklabel
Date: Mon, 28 Jul 2008 23:20:26 +0200	[thread overview]
Message-ID: <20080728212026.GA7386@thorin> (raw)
In-Reply-To: <200807281525.00219.Chris.Knadle@coredump.us>

On Mon, Jul 28, 2008 at 03:25:00PM -0400, Chris Knadle wrote:
> On Monday 28 July 2008, Felix Zielcke wrote:
> > Am Montag, den 28.07.2008, 14:41 -0400 schrieb Chris Knadle:
> > >    However on the last test I did make an error and left out the -d
> > > option to grub-probe, and that's required for the grub-probe to succeed,
> > > so unfortunately the output I posted is erroneous.
> > >    A new one is attached which has Robert's patch applied -- it does
> > > succeed in finding the partition, but unfortunately we can't fix the
> > > problem this way because I believe it makes Apple partition detection
> > > *always* fail.
> >
> > Urgs, yeah didn't see that.
> > You have to use -d if you give a device.
> > Why do you think that with this it will always fail?
> 
>    Because the test that the patch does is to check for an HFS+ filesystem 
> magic number against the first 2 bytes on the drive, which contains a jump 
> vector for the Grub stage1 binary.  i.e. in order for the test to pass, Grub 
> has to be unbootable.

My check has nothing to do with HFS+, it's based on the header magic number
(0x4552), which differs from the partition magic (0x504D) but also from the
HFS+ magic (0x482B, 0x4858).

Please could you test it against an apple partmap?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



  reply	other threads:[~2008-07-28 21:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-13 21:34 grub-probe fails to find PC partition due to Apple disklabel Chris Knadle
2008-04-14 12:07 ` Robert Millan
2008-04-14 14:21   ` Chris Knadle
2008-04-14 17:20     ` Pavel Roskin
2008-04-15 13:15       ` Robert Millan
2008-04-15 15:17         ` Pavel Roskin
2008-04-15 14:06       ` Chris Knadle
2008-07-23  2:53       ` Chris Knadle
2008-07-23  3:48         ` Pavel Roskin
2008-07-23 19:10           ` Chris Knadle
2008-07-23 20:47             ` Chris Knadle
2008-07-25 20:27               ` Robert Millan
2008-07-25 23:09                 ` Chris Knadle
2008-07-27 19:53                   ` Felix Zielcke
2008-07-27 20:33                     ` Felix Zielcke
2008-07-28 18:41                     ` Chris Knadle
2008-07-28 18:55                       ` Felix Zielcke
2008-07-28 19:25                         ` Chris Knadle
2008-07-28 21:20                           ` Robert Millan [this message]
2008-07-28 22:38                             ` Robert Millan
2008-07-29  2:25                             ` Chris Knadle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080728212026.GA7386@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.