All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Kevin Hickey <khickey@rmicorp.com>
Cc: linux-mips@linux-mips.org, dmitri.vorobiev@movial.fi
Subject: Re: [PATCH v2 1/1][MIPS] Initialization of Alchemy boards
Date: Mon, 28 Jul 2008 23:36:03 +0100	[thread overview]
Message-ID: <20080728223603.GA1430@linux-mips.org> (raw)
In-Reply-To: <1217268566.19887.3.camel@kh-ubuntu.razamicroelectronics.com>

On Mon, Jul 28, 2008 at 01:09:26PM -0500, Kevin Hickey wrote:

>   An earlier update changed some calls from simple_strotl to
> strict_strtol but did not account for the differences in the syntax
> between the calls.simple_strotl returns the integer; strict_strtol
> returns an error code and takes a pointer to the result.  As it was,
> NULL was being passed in place of the result, which led to failures
> during kernel initialization when using YAMON.
> 
> Signed-off-by:  Kevin Hickey <khickey@rmicorp.com>
> 
>  arch/mips/au1000/db1x00/init.c  |    2 +-
>  arch/mips/au1000/mtx-1/init.c   |    2 +-
>  arch/mips/au1000/pb1000/init.c  |    2 +-
>  arch/mips/au1000/pb1100/init.c  |    2 +-
>  arch/mips/au1000/pb1200/init.c  |    2 +-
>  arch/mips/au1000/pb1500/init.c  |    2 +-
>  arch/mips/au1000/pb1550/init.c  |    2 +-
>  arch/mips/au1000/xxs1500/init.c |    2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)

One little nit on the submission format - if you include a diffstat, please
put it after a line consisting only of three - like this:

---
 arch/mips/au1000/db1x00/init.c  |    2 +-
 arch/mips/au1000/mtx-1/init.c   |    2 +-
 arch/mips/au1000/pb1000/init.c  |    2 +-

This keeps git and other tools that try to extract the body of the mail
for the description from considering the diffstat as part of the
description.

Patch applied, thanks!

  Ralf

  reply	other threads:[~2008-07-28 22:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-28 18:09 [PATCH v2 1/1][MIPS] Initialization of Alchemy boards Kevin Hickey
2008-07-28 22:36 ` Ralf Baechle [this message]
2008-07-29  3:56   ` Kevin Hickey
2008-07-29  5:10     ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080728223603.GA1430@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=dmitri.vorobiev@movial.fi \
    --cc=khickey@rmicorp.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.