From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([66.187.233.31]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1KNezQ-0004U0-Jv for kexec@lists.infradead.org; Tue, 29 Jul 2008 02:31:04 +0000 Date: Mon, 28 Jul 2008 22:28:22 -0400 From: Vivek Goyal Subject: Re: [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Message-ID: <20080729022822.GA25975@redhat.com> References: <20080727234529.GM6175@verge.net.au> <20080728015117.GA12055@verge.net.au> <20080728024526.GB3334@verge.net.au> <20080728034007.GA30450@verge.net.au> <20080728211025.GA9985@redhat.com> <20080729012245.GI10434@verge.net.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20080729012245.GI10434@verge.net.au> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Simon Horman Cc: Muli Ben-Yehuda , Tony Luck , linux-ia64@vger.kernel.org, Chandru , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Terry Loftin , Paul Mundt , Paul Mackerras , "Eric W. Biederman" , Andrew Morton , Linus Torvalds , Ingo Molnar On Tue, Jul 29, 2008 at 11:22:48AM +1000, Simon Horman wrote: > On Mon, Jul 28, 2008 at 03:47:41PM -0700, Eric W. Biederman wrote: > > Vivek Goyal writes: > > > > > Hi All, > > > > > > How does following series of patches look like. I have moved > > > elfcorehdr_addr out of vmcore.c and pushed it to arch dependent section > > > of crash dump to make sure that it can be worked with even when > > > CONFIG_PROC_VMCORE is disabled and CONFIG_CRASH_DUMP is enabled. > > > > > > I tested it on x86_64. Compile tested it on i386 and ppc64. ia64 and > > > sh versions are completely untested. > > > > Given the current state of the code: > > Acked-by: "Eric W. Biederman" > > > > To process a kernel crash dump we pass the kernel elfcorehdr option, > > so testing to see if it was passed seems reasonable. > > > > In general I think this method of handling the problems with kdump is > > too brittle to live, but in the case of iommus we certainly need to do > > something different, and unfortunately iommus were not common on x86 > > when the original code was merged so we have not handled them well. > > Agreed, however these patches look like they really ought to be merged > into a single patch for the sake of bisect. As things stand, applying > the first patch will break the build on each architecture with an > architecture specific until the latter is applied. That's a good point. I was not very sure because changes were in different arches and I broke the patch. At the same time changes are really miniscule in each arch. So, for the sake of not breaking compilation for git-bisect, I will generate a single patch tomorrow. (Until and unless somebody has an objection). Thanks Vivek > > -- > Horms _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Date: Tue, 29 Jul 2008 02:28:22 +0000 Subject: Re: [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: Message-Id: <20080729022822.GA25975@redhat.com> List-Id: References: <20080727234529.GM6175@verge.net.au> <20080728015117.GA12055@verge.net.au> <20080728024526.GB3334@verge.net.au> <20080728034007.GA30450@verge.net.au> <20080728211025.GA9985@redhat.com> <20080729012245.GI10434@verge.net.au> In-Reply-To: <20080729012245.GI10434@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Simon Horman Cc: "Eric W. Biederman" , Andrew Morton , Muli Ben-Yehuda , Tony Luck , linux-ia64@vger.kernel.org, Chandru , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Terry Loftin , Ingo Molnar , Linus Torvalds , Paul Mundt , Paul Mackerras , linuxppc-dev@ozlabs.org On Tue, Jul 29, 2008 at 11:22:48AM +1000, Simon Horman wrote: > On Mon, Jul 28, 2008 at 03:47:41PM -0700, Eric W. Biederman wrote: > > Vivek Goyal writes: > > > > > Hi All, > > > > > > How does following series of patches look like. I have moved > > > elfcorehdr_addr out of vmcore.c and pushed it to arch dependent section > > > of crash dump to make sure that it can be worked with even when > > > CONFIG_PROC_VMCORE is disabled and CONFIG_CRASH_DUMP is enabled. > > > > > > I tested it on x86_64. Compile tested it on i386 and ppc64. ia64 and > > > sh versions are completely untested. > > > > Given the current state of the code: > > Acked-by: "Eric W. Biederman" > > > > To process a kernel crash dump we pass the kernel elfcorehdr option, > > so testing to see if it was passed seems reasonable. > > > > In general I think this method of handling the problems with kdump is > > too brittle to live, but in the case of iommus we certainly need to do > > something different, and unfortunately iommus were not common on x86 > > when the original code was merged so we have not handled them well. > > Agreed, however these patches look like they really ought to be merged > into a single patch for the sake of bisect. As things stand, applying > the first patch will break the build on each architecture with an > architecture specific until the latter is applied. That's a good point. I was not very sure because changes were in different arches and I broke the patch. At the same time changes are really miniscule in each arch. So, for the sake of not breaking compilation for git-bisect, I will generate a single patch tomorrow. (Until and unless somebody has an objection). Thanks Vivek > > -- > Horms From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by ozlabs.org (Postfix) with ESMTP id B561ADDDEF for ; Tue, 29 Jul 2008 12:31:06 +1000 (EST) Date: Mon, 28 Jul 2008 22:28:22 -0400 From: Vivek Goyal To: Simon Horman Subject: Re: [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Message-ID: <20080729022822.GA25975@redhat.com> References: <20080727234529.GM6175@verge.net.au> <20080728015117.GA12055@verge.net.au> <20080728024526.GB3334@verge.net.au> <20080728034007.GA30450@verge.net.au> <20080728211025.GA9985@redhat.com> <20080729012245.GI10434@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20080729012245.GI10434@verge.net.au> Cc: Tony Luck , linux-ia64@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Terry Loftin , Paul Mundt , Paul Mackerras , "Eric W. Biederman" , Andrew Morton , Linus Torvalds , Ingo Molnar List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jul 29, 2008 at 11:22:48AM +1000, Simon Horman wrote: > On Mon, Jul 28, 2008 at 03:47:41PM -0700, Eric W. Biederman wrote: > > Vivek Goyal writes: > > > > > Hi All, > > > > > > How does following series of patches look like. I have moved > > > elfcorehdr_addr out of vmcore.c and pushed it to arch dependent section > > > of crash dump to make sure that it can be worked with even when > > > CONFIG_PROC_VMCORE is disabled and CONFIG_CRASH_DUMP is enabled. > > > > > > I tested it on x86_64. Compile tested it on i386 and ppc64. ia64 and > > > sh versions are completely untested. > > > > Given the current state of the code: > > Acked-by: "Eric W. Biederman" > > > > To process a kernel crash dump we pass the kernel elfcorehdr option, > > so testing to see if it was passed seems reasonable. > > > > In general I think this method of handling the problems with kdump is > > too brittle to live, but in the case of iommus we certainly need to do > > something different, and unfortunately iommus were not common on x86 > > when the original code was merged so we have not handled them well. > > Agreed, however these patches look like they really ought to be merged > into a single patch for the sake of bisect. As things stand, applying > the first patch will break the build on each architecture with an > architecture specific until the latter is applied. That's a good point. I was not very sure because changes were in different arches and I broke the patch. At the same time changes are really miniscule in each arch. So, for the sake of not breaking compilation for git-bisect, I will generate a single patch tomorrow. (Until and unless somebody has an objection). Thanks Vivek > > -- > Horms From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757674AbYG2Cb2 (ORCPT ); Mon, 28 Jul 2008 22:31:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753171AbYG2CbO (ORCPT ); Mon, 28 Jul 2008 22:31:14 -0400 Received: from mx1.redhat.com ([66.187.233.31]:53376 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbYG2CbN (ORCPT ); Mon, 28 Jul 2008 22:31:13 -0400 Date: Mon, 28 Jul 2008 22:28:22 -0400 From: Vivek Goyal To: Simon Horman Cc: "Eric W. Biederman" , Andrew Morton , Muli Ben-Yehuda , Tony Luck , linux-ia64@vger.kernel.org, Chandru , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Terry Loftin , Ingo Molnar , Linus Torvalds , Paul Mundt , Paul Mackerras , linuxppc-dev@ozlabs.org Subject: Re: [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Message-ID: <20080729022822.GA25975@redhat.com> References: <20080727234529.GM6175@verge.net.au> <20080728015117.GA12055@verge.net.au> <20080728024526.GB3334@verge.net.au> <20080728034007.GA30450@verge.net.au> <20080728211025.GA9985@redhat.com> <20080729012245.GI10434@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080729012245.GI10434@verge.net.au> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 29, 2008 at 11:22:48AM +1000, Simon Horman wrote: > On Mon, Jul 28, 2008 at 03:47:41PM -0700, Eric W. Biederman wrote: > > Vivek Goyal writes: > > > > > Hi All, > > > > > > How does following series of patches look like. I have moved > > > elfcorehdr_addr out of vmcore.c and pushed it to arch dependent section > > > of crash dump to make sure that it can be worked with even when > > > CONFIG_PROC_VMCORE is disabled and CONFIG_CRASH_DUMP is enabled. > > > > > > I tested it on x86_64. Compile tested it on i386 and ppc64. ia64 and > > > sh versions are completely untested. > > > > Given the current state of the code: > > Acked-by: "Eric W. Biederman" > > > > To process a kernel crash dump we pass the kernel elfcorehdr option, > > so testing to see if it was passed seems reasonable. > > > > In general I think this method of handling the problems with kdump is > > too brittle to live, but in the case of iommus we certainly need to do > > something different, and unfortunately iommus were not common on x86 > > when the original code was merged so we have not handled them well. > > Agreed, however these patches look like they really ought to be merged > into a single patch for the sake of bisect. As things stand, applying > the first patch will break the build on each architecture with an > architecture specific until the latter is applied. That's a good point. I was not very sure because changes were in different arches and I broke the patch. At the same time changes are really miniscule in each arch. So, for the sake of not breaking compilation for git-bisect, I will generate a single patch tomorrow. (Until and unless somebody has an objection). Thanks Vivek > > -- > Horms