From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
torvalds@linux-foundation.org, hifumi.hisashi@oss.ntt.co.jp,
jack@ucw.cz, linux-ext4@vger.kernel.org
Subject: Re: [patch 12/17] vfs: pagecache usage optimization for pagesize!=blocksize
Date: Tue, 29 Jul 2008 11:11:42 +1000 [thread overview]
Message-ID: <200807291111.42941.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <20080728160904.f644fb85.akpm@linux-foundation.org>
On Tuesday 29 July 2008 09:09, Andrew Morton wrote:
> On Mon, 28 Jul 2008 19:00:32 -0400
>
> Christoph Hellwig <hch@infradead.org> wrote:
> > On Mon, Jul 28, 2008 at 03:46:36PM -0700, akpm@linux-foundation.org wrote:
> > > From: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
> > >
> > > When we read some part of a file through pagecache, if there is a
> > > pagecache of corresponding index but this page is not uptodate, read IO
> > > is issued and this page will be uptodate.
> >
> > I was under the impression we wanted to do this in a nicer way than
> > the hacky method?
>
> The only description I've seen of "a nicer way" is vague two-word
> descriptions of "changing readpage". Or something. No indication of
> what those changes are, nor who will implement them nor when.
>
> That just isn't solid enough to block a change which has significant
> performance benefits.
Yes I thought it would be nicer to do it by changing readpage, but I
said I'm happy to try to consolidate them myself down the track. It
is fairly low impact on core code.
next prev parent reply other threads:[~2008-07-29 1:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 22:46 [patch 12/17] vfs: pagecache usage optimization for pagesize!=blocksize akpm
2008-07-28 23:00 ` Christoph Hellwig
2008-07-28 23:09 ` Andrew Morton
2008-07-29 1:11 ` Nick Piggin [this message]
2008-08-04 7:19 ` Nick Piggin
2008-08-06 5:36 ` Nick Piggin
2008-08-06 5:36 ` Nick Piggin
2008-08-12 3:57 ` Hisashi Hifumi
2008-08-12 6:07 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807291111.42941.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=hifumi.hisashi@oss.ntt.co.jp \
--cc=jack@ucw.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.