From: Theodore Tso <tytso@MIT.EDU>
To: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
sugita <yumiko.sugita.yf@hitachi.com>,
Satoshi OSHIMA <satoshi.oshima.fk@hitachi.com>
Subject: Re: [PATCH] jbd2: don't abort if flushing file data failed
Date: Tue, 29 Jul 2008 08:35:13 -0400 [thread overview]
Message-ID: <20080729123513.GG9378@mit.edu> (raw)
In-Reply-To: <488EB060.7080303@hitachi.com>
On Tue, Jul 29, 2008 at 02:53:36PM +0900, Hidehiro Kawai wrote:
> Hello, Ted
>
> > [PATCH] ext4: don't read inode block if the buffer has a write error
> > [PATCH] jbd2: don't abort if flushing file data failed
>
> Thank you for porting my ext3/jbd patches to ext4/jbd2.
> I would appreciate if you port the remained two patch set (haven't
> been posted yet), too. Although I'll try to port them by myself.
If they are the ones which I think you are referring to, I don't
believe they apply to ext4 since we are now using the
generic_writepages routines to flush data pages to disk during a
journal commit. I've checked those code paths, and I believe they do
set AS_EIO correctly; I would appreciate it though if you could double
check to make sure they are do everything that needs to be done to
handle write errors correctly.
Thanks, regards,
- Ted
next prev parent reply other threads:[~2008-07-29 12:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 0:26 [PATCH] ext4: Cleanup whitespace and other miscellaneous style issues Theodore Ts'o
2008-07-27 0:26 ` [PATCH] ext4: don't read inode block if the buffer has a write error Theodore Ts'o
2008-07-27 0:26 ` [PATCH] ext4: unexport jbd2_journal_update_superblock Theodore Ts'o
2008-07-27 0:26 ` [PATCH] jbd2: don't abort if flushing file data failed Theodore Ts'o
2008-07-29 5:53 ` Hidehiro Kawai
2008-07-29 12:35 ` Theodore Tso [this message]
2008-07-31 6:00 ` Hidehiro Kawai
2008-08-01 2:33 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729123513.GG9378@mit.edu \
--to=tytso@mit.edu \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=linux-ext4@vger.kernel.org \
--cc=satoshi.oshima.fk@hitachi.com \
--cc=yumiko.sugita.yf@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.