From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mta23.gyao.ne.jp ([125.63.38.249] helo=mx.gate01.com) by bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux)) id 1KNq3F-0000WJ-AH for kexec@lists.infradead.org; Tue, 29 Jul 2008 14:19:46 +0000 Date: Tue, 29 Jul 2008 23:18:35 +0900 From: Paul Mundt Subject: Re: [PATCH 5/5] sh: Define elfcorehdr_addr in arch dependent section Message-ID: <20080729141835.GC902@linux-sh.org> References: <20080727234529.GM6175@verge.net.au> <20080728015117.GA12055@verge.net.au> <20080728024526.GB3334@verge.net.au> <20080728034007.GA30450@verge.net.au> <20080728211025.GA9985@redhat.com> <20080728211156.GB9985@redhat.com> <20080728211314.GC9985@redhat.com> <20080728211408.GD9985@redhat.com> <20080728211514.GE9985@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20080728211514.GE9985@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Vivek Goyal Cc: Muli Ben-Yehuda , Tony Luck , linux-ia64@vger.kernel.org, Chandru , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Terry Loftin , Simon Horman , Paul Mackerras , "Eric W. Biederman" , Andrew Morton , Linus Torvalds , Ingo Molnar On Mon, Jul 28, 2008 at 05:15:14PM -0400, Vivek Goyal wrote: > o Move elfcorehdr_addr definition in arch dependent crash dump file. This is > equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of > CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be > used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or > not. > > o I don't see sh setup code parsing the command line for elfcorehdr_addr. I > am wondering how does vmcore interface work on sh. Anyway, I am atleast > defining elfcoredhr_addr so that compilation is not broken on sh. > Hmm, you are correct, it seems like it was either lost in a merge somewhere or I simply neglected to check it in it when I was testing this stuff initially. Thanks for noticing! > Signed-off-by: Vivek Goyal Acked-by: Paul Mundt _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Tue, 29 Jul 2008 14:18:35 +0000 Subject: Re: [PATCH 5/5] sh: Define elfcorehdr_addr in arch dependent section Message-Id: <20080729141835.GC902@linux-sh.org> List-Id: References: <20080727234529.GM6175@verge.net.au> <20080728015117.GA12055@verge.net.au> <20080728024526.GB3334@verge.net.au> <20080728034007.GA30450@verge.net.au> <20080728211025.GA9985@redhat.com> <20080728211156.GB9985@redhat.com> <20080728211314.GC9985@redhat.com> <20080728211408.GD9985@redhat.com> <20080728211514.GE9985@redhat.com> In-Reply-To: <20080728211514.GE9985@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vivek Goyal Cc: Simon Horman , Andrew Morton , Muli Ben-Yehuda , Tony Luck , linux-ia64@vger.kernel.org, Chandru , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Terry Loftin , "Eric W. Biederman" , Ingo Molnar , Linus Torvalds , Paul Mackerras , linuxppc-dev@ozlabs.org On Mon, Jul 28, 2008 at 05:15:14PM -0400, Vivek Goyal wrote: > o Move elfcorehdr_addr definition in arch dependent crash dump file. This is > equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of > CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be > used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or > not. > > o I don't see sh setup code parsing the command line for elfcorehdr_addr. I > am wondering how does vmcore interface work on sh. Anyway, I am atleast > defining elfcoredhr_addr so that compilation is not broken on sh. > Hmm, you are correct, it seems like it was either lost in a merge somewhere or I simply neglected to check it in it when I was testing this stuff initially. Thanks for noticing! > Signed-off-by: Vivek Goyal Acked-by: Paul Mundt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx.gate01.com (mta23.gyao.ne.jp [125.63.38.249]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8A4D7DE0AF for ; Wed, 30 Jul 2008 00:19:49 +1000 (EST) Date: Tue, 29 Jul 2008 23:18:35 +0900 From: Paul Mundt To: Vivek Goyal Subject: Re: [PATCH 5/5] sh: Define elfcorehdr_addr in arch dependent section Message-ID: <20080729141835.GC902@linux-sh.org> References: <20080727234529.GM6175@verge.net.au> <20080728015117.GA12055@verge.net.au> <20080728024526.GB3334@verge.net.au> <20080728034007.GA30450@verge.net.au> <20080728211025.GA9985@redhat.com> <20080728211156.GB9985@redhat.com> <20080728211314.GC9985@redhat.com> <20080728211408.GD9985@redhat.com> <20080728211514.GE9985@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20080728211514.GE9985@redhat.com> Cc: Tony Luck , linux-ia64@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Terry Loftin , Simon Horman , Paul Mackerras , "Eric W. Biederman" , Andrew Morton , Linus Torvalds , Ingo Molnar List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jul 28, 2008 at 05:15:14PM -0400, Vivek Goyal wrote: > o Move elfcorehdr_addr definition in arch dependent crash dump file. This is > equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of > CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be > used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or > not. > > o I don't see sh setup code parsing the command line for elfcorehdr_addr. I > am wondering how does vmcore interface work on sh. Anyway, I am atleast > defining elfcoredhr_addr so that compilation is not broken on sh. > Hmm, you are correct, it seems like it was either lost in a merge somewhere or I simply neglected to check it in it when I was testing this stuff initially. Thanks for noticing! > Signed-off-by: Vivek Goyal Acked-by: Paul Mundt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758746AbYG2OU2 (ORCPT ); Tue, 29 Jul 2008 10:20:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756490AbYG2OUL (ORCPT ); Tue, 29 Jul 2008 10:20:11 -0400 Received: from mta23.gyao.ne.jp ([125.63.38.249]:35128 "EHLO mx.gate01.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755887AbYG2OUJ (ORCPT ); Tue, 29 Jul 2008 10:20:09 -0400 Date: Tue, 29 Jul 2008 23:18:35 +0900 From: Paul Mundt To: Vivek Goyal Cc: Simon Horman , Andrew Morton , Muli Ben-Yehuda , Tony Luck , linux-ia64@vger.kernel.org, Chandru , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Terry Loftin , "Eric W. Biederman" , Ingo Molnar , Linus Torvalds , Paul Mackerras , linuxppc-dev@ozlabs.org Subject: Re: [PATCH 5/5] sh: Define elfcorehdr_addr in arch dependent section Message-ID: <20080729141835.GC902@linux-sh.org> Mail-Followup-To: Paul Mundt , Vivek Goyal , Simon Horman , Andrew Morton , Muli Ben-Yehuda , Tony Luck , linux-ia64@vger.kernel.org, Chandru , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Terry Loftin , "Eric W. Biederman" , Ingo Molnar , Linus Torvalds , Paul Mackerras , linuxppc-dev@ozlabs.org References: <20080727234529.GM6175@verge.net.au> <20080728015117.GA12055@verge.net.au> <20080728024526.GB3334@verge.net.au> <20080728034007.GA30450@verge.net.au> <20080728211025.GA9985@redhat.com> <20080728211156.GB9985@redhat.com> <20080728211314.GC9985@redhat.com> <20080728211408.GD9985@redhat.com> <20080728211514.GE9985@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080728211514.GE9985@redhat.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 28, 2008 at 05:15:14PM -0400, Vivek Goyal wrote: > o Move elfcorehdr_addr definition in arch dependent crash dump file. This is > equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of > CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be > used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or > not. > > o I don't see sh setup code parsing the command line for elfcorehdr_addr. I > am wondering how does vmcore interface work on sh. Anyway, I am atleast > defining elfcoredhr_addr so that compilation is not broken on sh. > Hmm, you are correct, it seems like it was either lost in a merge somewhere or I simply neglected to check it in it when I was testing this stuff initially. Thanks for noticing! > Signed-off-by: Vivek Goyal Acked-by: Paul Mundt