From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: GIT 1.6.0-rc1
Date: Tue, 29 Jul 2008 23:17:45 +0200 [thread overview]
Message-ID: <20080729211745.GA3879@blimp.local> (raw)
In-Reply-To: <7vljzlhyt8.fsf@gitster.siamese.dyndns.org>
Junio C Hamano, Tue, Jul 29, 2008 10:36:19 +0200:
> Junio C Hamano <gitster@pobox.com> writes:
> >
> > Ok, I took a deeper look at the codepaths involved. Although it does work
> > around the issue, I do not think your patch alone is the "correct" one in
> > the longer term.
Thought so. I just didn't know the code around
> > It needs a bit of explanation, and the explanation won't be exactly
> > "plain, small and short", unfortunately.
>
> Alex, I ran the full test with this, but only on Linux boxes; obviously
> not on any flavor of Windows. I think it is correct, and the "first line
> of defence" fix is the same as your patch, so I'd assume it would work for
> you as well. But extra eyeballs are always appreciated.
Well, it works on Cygwin too. And I had my eyeballs on the code
(wondered first if it will cause more fs accesses than before: it
will, in the racy check. Which is correct, AFAICT)
next prev parent reply other threads:[~2008-07-29 21:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 0:09 GIT 1.6.0-rc1 Junio C Hamano
2008-07-28 0:44 ` Petr Baudis
2008-07-28 6:38 ` Alex Riesen
2008-07-28 6:44 ` Junio C Hamano
2008-07-28 21:37 ` Alex Riesen
2008-07-29 6:20 ` Junio C Hamano
2008-07-29 8:13 ` Junio C Hamano
2008-07-29 8:36 ` Junio C Hamano
2008-07-29 21:17 ` Alex Riesen [this message]
2008-07-29 22:03 ` Junio C Hamano
2008-07-30 6:10 ` Alex Riesen
2008-07-30 6:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729211745.GA3879@blimp.local \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.