From: Andrew Morton <akpm@linux-foundation.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>, lguest <lguest@ozlabs.org>,
linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH 1/2] Export get_user_pages_fast
Date: Wed, 30 Jul 2008 10:50:52 -0700 [thread overview]
Message-ID: <20080730105052.f05865d4.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080730173944.GC28604@cs181140183.pp.htv.fi>
On Wed, 30 Jul 2008 20:39:44 +0300 Adrian Bunk <bunk@kernel.org> wrote:
> > On non-CONFIG_HAVE_GET_USER_PAGES_FAST architectures a
> > get_user_pages_fast() call will in fact call get_user_pages().
> >
> > On CONFIG_HAVE_GET_USER_PAGES_FAST architectures, get_user_pages_fast()
> > is a real function. All architectures which implement that function
> > should export it to modules. Hence it should be exported from within
> > generic code.
>
> Are we talking at cross purposes?
Apparently.
> I thought you were talking an error due to a missing function.
Nope.
> If you think about an error where the function is present but only the
> EXPORT_SYMBOL is missing
yup.
> then I get your point (although I do not
> consider it a huge problem).
Me either.
next prev parent reply other threads:[~2008-07-30 17:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 4:38 [PATCH 1/2] Export get_user_pages_fast Rusty Russell
2008-07-30 4:39 ` [PATCH 2/2] lguest: use get_user_pages_fast() instead of get_user_pages() Rusty Russell
2008-07-30 5:30 ` Nick Piggin
2008-07-30 6:53 ` Rusty Russell
2008-07-30 5:23 ` [PATCH 1/2] Export get_user_pages_fast Nick Piggin
2008-07-30 10:35 ` Andrew Morton
2008-07-30 15:47 ` Adrian Bunk
2008-07-30 17:03 ` Andrew Morton
2008-07-30 17:09 ` Adrian Bunk
2008-07-30 17:14 ` Andrew Morton
2008-07-30 17:18 ` Adrian Bunk
2008-07-30 17:28 ` Andrew Morton
2008-07-30 17:39 ` Adrian Bunk
2008-07-30 17:50 ` Andrew Morton [this message]
2008-07-30 17:23 ` Avi Kivity
2008-07-30 17:29 ` Andrew Morton
2008-07-31 6:43 ` Avi Kivity
2008-07-31 7:02 ` Andrew Morton
2008-07-31 8:10 ` Nick Piggin
2008-07-31 8:21 ` Andrew Morton
2008-07-31 8:32 ` Benjamin Herrenschmidt
2008-07-31 8:48 ` Nick Piggin
2008-07-31 8:52 ` Benjamin Herrenschmidt
2008-07-31 8:56 ` Nick Piggin
2008-08-05 5:47 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730105052.f05865d4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.