From: Andrew Morton <akpm@linux-foundation.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, randy.dunlap@oracle.com,
ankita@in.ibm.com, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [patch 10/12] lkdtm: fix for CONFIG_SCSI=n
Date: Wed, 30 Jul 2008 13:42:43 -0700 [thread overview]
Message-ID: <20080730134243.d2b9894b.akpm@linux-foundation.org> (raw)
In-Reply-To: <1217449008.3335.39.camel@localhost.localdomain>
On Wed, 30 Jul 2008 15:16:48 -0500
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Wed, 2008-07-30 at 12:44 -0700, akpm@linux-foundation.org wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Fix lkdtm test code for case of CONFIG_SCSI=n, to avoid build errors:
> >
> > In file included from linux-next-20080618/tests/lkdtm.c:55:
> > linux-next-20080618/include/scsi/scsi_cmnd.h:28:25: warning: "BLK_MAX_CDB" is not defined
> > linux-next-20080618/include/scsi/scsi_cmnd.h:29:3: error: #error MAX_COMMAND_SIZE can not be bigger than BLK_MAX_CDB
> > In file included from linux-next-20080618/tests/lkdtm.c:55:
> > linux-next-20080618/include/scsi/scsi_cmnd.h: In function 'scsi_bidi_cmnd':
> > linux-next-20080618/include/scsi/scsi_cmnd.h:183: error: implicit declaration of function 'blk_bidi_rq'
> > linux-next-20080618/include/scsi/scsi_cmnd.h:184: error: dereferencing pointer to incomplete type
> > linux-next-20080618/include/scsi/scsi_cmnd.h: In function 'scsi_in':
> > linux-next-20080618/include/scsi/scsi_cmnd.h:190: error: dereferencing pointer to incomplete type
> > make[2]: *** [tests/lkdtm.o] Error 1
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > Acked-by: Ankita Garg <ankita@in.ibm.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> >
> > tests/lkdtm.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff -puN tests/lkdtm.c~lkdtm-fix-for-config_scsi=n tests/lkdtm.c
> > --- a/tests/lkdtm.c~lkdtm-fix-for-config_scsi=n
> > +++ a/tests/lkdtm.c
>
> OK, you've sent me this one twice now ... what exactly is it?
Why didn't you tell me last time?
> There's
> no tests directory in any kernel tree I have.
You don't have a copy of linux-next? Wow.
I'll send it to Sam.
next prev parent reply other threads:[~2008-07-30 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 19:44 [patch 10/12] lkdtm: fix for CONFIG_SCSI=n akpm
2008-07-30 20:16 ` James Bottomley
2008-07-30 20:42 ` Andrew Morton [this message]
2008-07-30 20:47 ` James Bottomley
2008-07-30 20:55 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730134243.d2b9894b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ankita@in.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.