From: Sam Ravnborg <sam@ravnborg.org>
To: Karsten Keil <kkeil@suse.de>
Cc: David Woodhouse <dwmw2@infradead.org>,
isdn4linux@listserv.isdn4linux.de,
Marcel Holtmann <marcel@holtmann.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mISDN cleanup user interface
Date: Wed, 30 Jul 2008 20:37:21 +0200 [thread overview]
Message-ID: <20080730183721.GA29639@uranus.ravnborg.org> (raw)
In-Reply-To: <20080730175138.GA12800@pingi.kke.suse.de>
On Wed, Jul 30, 2008 at 07:51:38PM +0200, Karsten Keil wrote:
> On Wed, Jul 30, 2008 at 05:57:01PM +0100, David Woodhouse wrote:
> > On Wed, 2008-07-30 at 18:33 +0200, Karsten Keil wrote:
> > > What about this implementation ?
> >
> > Looks a lot saner... although it does seem to confirm my earlier
> > suspicion that you're not even _using_ the fact that it's a bitmap at
> > all. You set the bits for the present channels at init time, which are
> > always contiguous, and you never seem to change them them later -- why
> > couldn't you do this with a simple 'number of channels' integer?
>
> No it is not contineous on different PRI line setups (E1,T1 ...)
> e.g a E1 has the D-channel on channel 15 position, so this bit is not set
> then.
timeslot 16 in my book actually - but maybe that your timeslot to
channel mapping.
Not that it has anything to do with the topic discussed!
Sam
next prev parent reply other threads:[~2008-07-30 18:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 19:56 [PATCH] mISDN cleanup user interface Karsten Keil
2008-07-29 20:22 ` David Woodhouse
2008-07-29 21:02 ` Marcel Holtmann
2008-07-30 9:13 ` David Woodhouse
2008-07-30 16:33 ` Karsten Keil
2008-07-30 16:57 ` David Woodhouse
2008-07-30 17:51 ` Karsten Keil
2008-07-30 18:37 ` Sam Ravnborg [this message]
2008-07-30 18:46 ` Karsten Keil
2008-07-30 19:08 ` David Woodhouse
2008-07-30 15:08 ` Karsten Keil
2008-08-01 17:21 ` Linus Torvalds
2008-08-02 15:21 ` Karsten Keil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730183721.GA29639@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=dwmw2@infradead.org \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.