All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Schermerhorn <lee.schermerhorn@hp.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Rik van Riel <riel@surriel.com>,
	Eric.Whitney@hp.com,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: [PATCH 1/7] unevictable lru:  Remember page's active state
Date: Wed, 30 Jul 2008 16:06:24 -0400	[thread overview]
Message-ID: <20080730200624.24272.7234.sendpatchset@lts-notebook> (raw)
In-Reply-To: <20080730200618.24272.31756.sendpatchset@lts-notebook>

Fix to unevictable-lru-infrastructure.patch

Not sure this is absolutely required, but:

Preserve page's incoming active flag across retries in
putback_lru_page().


Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>

 mm/vmscan.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6.27-rc1-mmotm-30jul/mm/vmscan.c
===================================================================
--- linux-2.6.27-rc1-mmotm-30jul.orig/mm/vmscan.c	2008-07-30 12:57:31.000000000 -0400
+++ linux-2.6.27-rc1-mmotm-30jul/mm/vmscan.c	2008-07-30 12:58:41.000000000 -0400
@@ -483,12 +483,12 @@ int remove_mapping(struct address_space 
 void putback_lru_page(struct page *page)
 {
 	int lru;
+	int active = !!TestClearPageActive(page);
 	int was_unevictable = PageUnevictable(page);
 
 	VM_BUG_ON(PageLRU(page));
 
 redo:
-	lru = !!TestClearPageActive(page);
 	ClearPageUnevictable(page);
 
 	if (page_evictable(page, NULL)) {
@@ -498,7 +498,7 @@ redo:
 		 * unevictable page on [in]active list.
 		 * We know how to handle that.
 		 */
-		lru += page_is_file_cache(page);
+		lru = active + page_is_file_cache(page);
 		lru_cache_add_lru(page, lru);
 	} else {
 		/*

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-07-30 20:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 20:06 [PATCH 0/7] mmotm - unevictable lru/mlocked pages fixes/cleanup Lee Schermerhorn
2008-07-30 20:06 ` Lee Schermerhorn [this message]
2008-07-30 20:31   ` [PATCH 1/7] unevictable lru: Remember page's active state KOSAKI Motohiro
2008-07-30 20:06 ` [PATCH 2/7] unevictable lru: defer vm event counting Lee Schermerhorn
2008-07-30 20:33   ` KOSAKI Motohiro
2008-07-30 20:06 ` [PATCH 3/7] unevictable lru: add event counting with statistics Lee Schermerhorn
2008-07-30 20:34   ` KOSAKI Motohiro
2008-07-30 20:06 ` [PATCH 4/7] unevictable lru: add event counts to list scan Lee Schermerhorn
2008-07-30 20:37   ` KOSAKI Motohiro
2008-07-30 20:06 ` [PATCH 5/7] mlocked-pages: add event counting with statistics Lee Schermerhorn
2008-07-30 20:40   ` KOSAKI Motohiro
2008-07-30 21:00     ` Lee Schermerhorn
2008-07-30 20:06 ` [PATCH 6/7] mlocked-pages: patch reject resolution and event renames Lee Schermerhorn, Lee Schermerhorn
2008-07-30 20:30   ` Andrew Morton
2008-07-30 21:03     ` Lee Schermerhorn
2008-07-30 22:46     ` Rik van Riel
2008-07-30 20:07 ` [PATCH/DESCRIPTION 7/7] unevictable lru: replace patch description Lee Schermerhorn
2008-07-30 20:48   ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080730200624.24272.7234.sendpatchset@lts-notebook \
    --to=lee.schermerhorn@hp.com \
    --cc=Eric.Whitney@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=riel@surriel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.