From: Andrew Morton <akpm@linux-foundation.org>
To: David Teigland <teigland@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] dlm updates for 2.6.27
Date: Wed, 30 Jul 2008 21:35:56 -0700 [thread overview]
Message-ID: <20080730213556.df1fed99.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080728161158.GA981@redhat.com>
On Mon, 28 Jul 2008 11:11:58 -0500 David Teigland <teigland@redhat.com> wrote:
> please pull dlm updates for 2.6.27 from:
sparc allmodconfig explodes in -mm:
fs/dlm/config.c:282: error: redefinition of 'struct node'
fs/dlm/config.c:390: error: expected identifier or '(' before '{' token
fs/dlm/config.c: In function 'drop_node':
fs/dlm/config.c:582: error: 'struct node' has no member named 'sysdev'
fs/dlm/config.c:582: warning: type defaults to 'int' in declaration of '__mptr'
fs/dlm/config.c:582: warning: initialization from incompatible pointer type
fs/dlm/config.c:582: error: 'struct node' has no member named 'sysdev'
fs/dlm/config.c: In function 'release_node':
fs/dlm/config.c:594: error: 'struct node' has no member named 'sysdev'
fs/dlm/config.c:594: warning: type defaults to 'int' in declaration of '__mptr'
fs/dlm/config.c:594: warning: initialization from incompatible pointer type
fs/dlm/config.c:594: error: 'struct node' has no member named 'sysdev'
fs/dlm/config.c: In function 'show_node':
fs/dlm/config.c:708: error: 'struct node' has no member named 'sysdev'
fs/dlm/config.c:708: warning: type defaults to 'int' in declaration of '__mptr'
fs/dlm/config.c:708: warning: initialization from incompatible pointer type
fs/dlm/config.c:708: error: 'struct node' has no member named 'sysdev'
fs/dlm/config.c: In function 'store_node':
fs/dlm/config.c:717: error: 'struct node' has no member named 'sysdev'
fs/dlm/config.c:717: warning: type defaults to 'int' in declaration of '__mptr'
fs/dlm/config.c:717: warning: initialization from incompatible pointer type
fs/dlm/config.c:717: error: 'struct node' has no member named 'sysdev'
Because there's already a `struct node' in include/linux/node.h.
This is because some random unrelated patch
(vmscan-unevictable-lru-scan-sysctl.patch) in -mm has caused
include/linux/node.h to get included in the fs/dlm/config.c build on
sparc32.
`struct node' was a poor choice of name! Please rename it prior to the
2.6.27 release so that bisectability won't break if/when we merge
vmscan-unevictable-lru-scan-sysctl.patch. Plus this bug might already
be present in mainline, only nobody has yet found the config which
triggers it.
next prev parent reply other threads:[~2008-07-31 4:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 16:11 [GIT PULL] dlm updates for 2.6.27 David Teigland
2008-07-31 4:35 ` Andrew Morton [this message]
2008-07-31 15:06 ` David Teigland
-- strict thread matches above, loose matches on Subject: below --
2008-07-18 16:36 David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730213556.df1fed99.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.