From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: Qing He <qing.he@intel.com>
Cc: xen-devel@lists.xensource.com,
Keir Fraser <keir.fraser@eu.citrix.com>,
Diego Ongaro <diego.ongaro@citrix.com>
Subject: Re: [PATCH] gnttab_setup_table error case
Date: Thu, 31 Jul 2008 09:58:58 +0100 [thread overview]
Message-ID: <20080731085858.GE5427@implementation> (raw)
In-Reply-To: <20080731020828.GA5842@ub-qhe2>
Qing He, le Thu 31 Jul 2008 10:08:28 +0800, a écrit :
> On Wed, 2008-07-30 at 14:17 +0100, Diego Ongaro wrote:
> > gnttab_setup_table should set an error status code if the gmfn it gets
> > for a grant table page is invalid.
> >
> > I ran into this issue when I tried to set up the grant table during hvm
> > domain creation, and it caused a BUG_ON later down the line. With this
> > patch, the hypercall will gracefully fail instead.
>
> Do you use 32bit guest on top of 64bit hypervisor?
No, just 64/64.
> Just curious, but why we want to call setup_table in HVM in the first
> place. Since HVM has its isolated address space, it will always fail.
That was for his personal project. The call was made from dom0. The
problem is that it triggers a BUG_ON, which we do not really want to
happen :)
> 1. let setup_table return -ENOSYS again in HVM?
That could make sense.
Samuel
next prev parent reply other threads:[~2008-07-31 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 13:17 [PATCH] gnttab_setup_table error case Diego Ongaro
2008-07-31 2:08 ` Qing He
2008-07-31 8:58 ` Samuel Thibault [this message]
2008-07-31 13:12 ` Diego Ongaro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731085858.GE5427@implementation \
--to=samuel.thibault@eu.citrix.com \
--cc=diego.ongaro@citrix.com \
--cc=keir.fraser@eu.citrix.com \
--cc=qing.he@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.