From: Ingo Molnar <mingo@elte.hu>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: Jan Beulich <jbeulich@novell.com>,
Andi Kleen <andi@firstfloor.org>,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH] i386: improve double fault handling
Date: Thu, 31 Jul 2008 12:46:52 +0200 [thread overview]
Message-ID: <20080731104651.GJ488@elte.hu> (raw)
In-Reply-To: <488E4166.5070304@redhat.com>
* Chuck Ebbert <cebbert@redhat.com> wrote:
> Ingo Molnar wrote:
>>
>> All CPUs hitting a double fault simultaneously and corrupting each
>> others' kernel stack is a theoretical possibility - but is handling it
>> worth the complexity? It appears to me that a lock plus a short stub
>> function that takes the lock (with no stack usage) would handle that
>> much better.
>
> That can't happen now because the TSS gets marked busy so we will get
> a triple fault instead. One thing we might want to do in the current
> code is unset the busy flag after handling the fault and before we
> start looping at the end of the handler so we can handle another fault
> later.
that would be a nice improvement.
Ingo
next prev parent reply other threads:[~2008-07-31 10:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 12:30 [PATCH] i386: improve double fault handling Jan Beulich
2008-07-18 23:24 ` H. Peter Anvin
2008-07-21 8:54 ` Jan Beulich
2008-07-21 11:05 ` Ingo Molnar
2008-07-22 10:13 ` Jan Beulich
2008-07-28 13:42 ` Ingo Molnar
2008-07-28 13:45 ` H. Peter Anvin
2008-07-28 13:59 ` Jan Beulich
2008-07-28 14:02 ` H. Peter Anvin
2008-07-28 16:28 ` Ingo Molnar
2008-07-28 22:00 ` Chuck Ebbert
2008-07-31 10:46 ` Ingo Molnar [this message]
2008-07-23 21:43 ` Joerg Roedel
2008-07-24 7:08 ` Jan Beulich
2008-07-24 13:24 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731104651.GJ488@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=cebbert@redhat.com \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.