All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: adel.gadllah@gmail.com, linux-scsi@vger.kernel.org,
	jens.axboe@oracle.com, James.Bottomley@hansenpartnership.com,
	dan.j.williams@intel.com, pjones@redhat.com,
	viro@zeniv.linux.org.uk, dougg@torque.net
Subject: Re: [PATCH 0/3] cmd_filter fixes
Date: Thu, 31 Jul 2008 07:04:22 -0600	[thread overview]
Message-ID: <20080731130422.GC30534@parisc-linux.org> (raw)
In-Reply-To: <20080731162449X.fujita.tomonori@lab.ntt.co.jp>

On Thu, Jul 31, 2008 at 04:24:54PM +0900, FUJITA Tomonori wrote:
> > We need to be able to delete as well as add.
> 
> Yeah, I thought about adding a new file such as read_table_off.

Three files seems excessive.  Plus the +/- notation lets you do:

echo -- +0x02 +0x03 -0x08

atomically.  I don't know if that's an important feature to have.

> Looks another potential option though I prefer "-0x03" than "-03" as I
> said in the previous mail.

Makes sense.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

  reply	other threads:[~2008-07-31 13:04 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-13 19:33 [PATCH/RFC] allow userspace to modify scsi command filter on per device basis Adel Gadllah
2008-06-13 19:54 ` Matthew Wilcox
2008-06-13 20:22   ` Adel Gadllah
2008-06-13 20:23     ` Adel Gadllah
2008-06-14  6:51       ` [PATCH/RFC v2] " Adel Gadllah
2008-06-16  2:55         ` FUJITA Tomonori
2008-06-16  5:49           ` Adel Gadllah
2008-06-16  6:13             ` FUJITA Tomonori
2008-06-16  9:22               ` [PATCH/RFC v3] " Adel Gadllah
2008-06-17 20:14                 ` FUJITA Tomonori
2008-06-17 21:45                   ` Peter Jones
2008-06-17 22:40                     ` FUJITA Tomonori
2008-06-17 22:49                     ` FUJITA Tomonori
2008-06-17 23:01                     ` Douglas Gilbert
2008-06-18  1:13                       ` Pete Wyckoff
2008-06-18  7:33                       ` Adel Gadllah
2008-06-18 14:55                       ` James Smart
2008-06-18 14:56                       ` Peter Jones
2008-06-26 10:10                         ` Adel Gadllah
2008-06-26 10:13                           ` Jens Axboe
2008-06-26 14:36                           ` FUJITA Tomonori
2008-06-26 15:05                             ` Adel Gadllah
2008-06-26 15:08                               ` FUJITA Tomonori
2008-06-26 15:26                                 ` FUJITA Tomonori
2008-07-24  1:11                             ` Dan Williams
2008-07-24  3:31                               ` FUJITA Tomonori
2008-07-26  9:03                                 ` [PATCH 0/3] cmd_filter fixes FUJITA Tomonori
2008-07-26  9:03                                   ` [PATCH 1/3] move cmd_filter from gendisk to request_queue FUJITA Tomonori
2008-07-26  9:03                                     ` [PATCH 2/3] sg: restore command permission for TYPE_SCANNER FUJITA Tomonori
2008-07-26  9:03                                       ` [PATCH 3/3] rename blk_scsi_cmd_filter to blk_cmd_filter FUJITA Tomonori
2008-07-30 20:10                                     ` [PATCH 1/3] move cmd_filter from gendisk to request_queue Peter Jones
2008-07-31  5:13                                       ` FUJITA Tomonori
2008-08-16  5:47                                     ` FUJITA Tomonori
2008-07-27 19:59                                   ` [PATCH 0/3] cmd_filter fixes Adel Gadllah
2008-07-27 20:02                                     ` Adel Gadllah
2008-07-28  2:18                                       ` FUJITA Tomonori
2008-07-30 19:59                                         ` Adel Gadllah
2008-07-31  4:55                                           ` FUJITA Tomonori
2008-07-31  7:18                                             ` Matthew Wilcox
2008-07-31  7:24                                               ` FUJITA Tomonori
2008-07-31 13:04                                                 ` Matthew Wilcox [this message]
2008-07-31 15:18                                                   ` FUJITA Tomonori
2008-08-07 18:47                                                     ` Adel Gadllah
2008-08-08  0:20                                                       ` FUJITA Tomonori
2008-08-08  5:54                                                         ` Jens Axboe
2008-08-08  6:11                                                           ` FUJITA Tomonori
2008-08-08  6:15                                                             ` Jens Axboe
2008-08-08  6:29                                                               ` FUJITA Tomonori
2008-08-08  6:35                                                                 ` Jens Axboe
2008-08-08 16:53                                                                   ` [PATCH 1/2] drop vmerge accounting Mikulas Patocka
2008-08-08 17:07                                                                     ` [PATCH 2/2] " Mikulas Patocka
2008-08-15  9:48                                                                       ` Jens Axboe
2008-08-15 18:23                                                                         ` [PATCH 3/4] " Mikulas Patocka
2008-08-22  9:10                                                                           ` Jens Axboe
2008-08-22  9:17                                                                             ` Jens Axboe
2008-08-22 16:58                                                                               ` Mikulas Patocka
2008-08-22 17:05                                                                                 ` Mikulas Patocka
2008-08-22  9:29                                                                           ` Pierre Ossman
2008-08-22  9:33                                                                             ` Jens Axboe
2008-08-22 21:34                                                                               ` Mikulas Patocka
2008-08-22 21:35                                                                               ` [PATCH 4/4] " Mikulas Patocka
2008-08-15 18:26                                                                         ` Mikulas Patocka
2008-08-21  9:26                                                           ` [PATCH 0/3] cmd_filter fixes Adel Gadllah
2008-08-22  9:10                                                             ` Jens Axboe
2008-06-14 20:26   ` [PATCH/RFC] allow userspace to modify scsi command filter on per device basis Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080731130422.GC30534@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=adel.gadllah@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=dougg@torque.net \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jens.axboe@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pjones@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.