From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [PATCH] hvm: Use main memory for video memory. [Was:
	xend, 8MB video memory and ballooning]
Date: Thu, 31 Jul 2008 15:57:58 +0100
Message-ID: <20080731145758.GP4678@implementation.uk.xensource.com>
References: <20080731131850.GI4678@implementation.uk.xensource.com>
	<C4B77F3F.24EBF%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <C4B77F3F.24EBF%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Keir Fraser, le Thu 31 Jul 2008 14:39:59 +0100, a =E9crit :
> On 31/7/08 14:18, "Samuel Thibault" <samuel.thibault@eu.citrix.com> wro=
te:
>=20
> > diff -r 83b3a8a2a4f3 tools/libxc/xc_domain_save.c
> > --- a/tools/libxc/xc_domain_save.c Thu Jul 31 12:58:07 2008 +0100
> > +++ b/tools/libxc/xc_domain_save.c Thu Jul 31 13:20:02 2008 +0100
> > @@ -1112,9 +1112,7 @@ int xc_domain_save(int xc_handle, int io
> >                      continue;
> > =20
> >                  /* Skip PFNs that aren't really there */
> > -                if ( hvm && ((n >=3D 0xa0 && n < 0xc0) /* VGA hole *=
/
> > -                             || (n >=3D (HVM_BELOW_4G_MMIO_START >> =
PAGE_SHIFT)
> > -                                 && n < (1ULL<<32) >> PAGE_SHIFT)) /=
* MMIO */
> > )
> > +                if ( hvm && n =3D=3D shared_info_frame )
> >                      continue;
>=20
> What happens if you don't special-case shared_info_frame?

I actually hadn't even tried.

> I'd've hoped it would just work... does the extra page of allocation
> during restore fail?

It does work, but I guess it replaces the mapping of the "magic" page
with the mapping of the allocated page, so that shared_info wouldn't
work any more.

> I'm thinking that the grant tables will be mapped in the I/O hole too, =
and
> that is from 'Xen heap' just like shared_info is.

Urgl, hadn't thought about those, I guess the PV drivers would
re-etablish them on resume anyway?

> So special-casing one and not the other sure is odd.

Actually, shouldn't it be up to the hypervisor to not return all these
from the SHADOW_OP_PEEK operation?

Samuel