All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Paris <eparis@redhat.com>
Cc: zhangxiliang <zhangxiliang@cn.fujitsu.com>,
	sgrubb@redhat.com, Linux Audit <linux-audit@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix the bug of using AUDIT_STATUS_RATE_LIMIT when set fail, no error output.
Date: Thu, 31 Jul 2008 17:04:38 +0100	[thread overview]
Message-ID: <20080731160438.GK28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1217474150.2902.76.camel@localhost.localdomain>

On Wed, Jul 30, 2008 at 11:15:50PM -0400, Eric Paris wrote:
> On Thu, 2008-07-31 at 10:11 +0800, zhangxiliang wrote:
> > When the "status_get->mask" is "AUDIT_STATUS_RATE_LIMIT || AUDIT_STATUS_BACKLOG_LIMIT".
> > If "audit_set_rate_limit" fails and "audit_set_backlog_limit" succeeds, the "err" value will be greater than or equal to 0. It will miss the failure of rate set. 
> > 
> > Signed-off-by: Zhang Xiliang <zhangxiliang@cn.fujitsu.com>
> 
> man, it gives me the heebee jeebies with the coding style but it follows
> everything else

Sanitized, applied, pushed to audit-current (audit.b53)

  reply	other threads:[~2008-07-31 16:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31  2:11 [PATCH] Fix the bug of using AUDIT_STATUS_RATE_LIMIT when set fail, no error output zhangxiliang
2008-07-31  3:15 ` Eric Paris
2008-07-31  3:15   ` Eric Paris
2008-07-31 16:04   ` Al Viro [this message]
2008-07-31 21:59     ` Andrew Morton
2008-07-31 21:59       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080731160438.GK28946@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sgrubb@redhat.com \
    --cc=zhangxiliang@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.