From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch resend] vfs: move executable checking into ->permission()
Date: Thu, 31 Jul 2008 17:10:24 +0100 [thread overview]
Message-ID: <20080731161024.GL28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <E1KOWXe-0008Dl-ET@pomaz-ex.szeredi.hu>
On Thu, Jul 31, 2008 at 01:41:58PM +0200, Miklos Szeredi wrote:
> On Thu, 31 Jul 2008, Al Viro wrote:
> > On Wed, Jul 30, 2008 at 03:02:03PM +0200, Miklos Szeredi wrote:
> > > static int coda_ioctl_permission(struct inode *inode, int mask)
> > > {
> > > - return 0;
> > > + return check_execute(dentry->d_inode, mask);
> > > }
> >
> > Er?
> > a) mismerge from dentry-based variant
>
> Yeah, crappy patch. Agree on all other comments as well, thanks for
> the review.
Hrm... OK, behaviour change for permission() on bdev/cdev/pipe is
not a problems...
I'll apply it, but if anybody has better suggestions for helper name,
please yell. "execute_ok()" sounds very odd...
prev parent reply other threads:[~2008-07-31 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 13:02 [patch resend] vfs: move executable checking into ->permission() Miklos Szeredi
2008-07-31 0:33 ` Al Viro
2008-07-31 11:41 ` Miklos Szeredi
2008-07-31 16:10 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731161024.GL28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.