From: Ingo Molnar <mingo@elte.hu>
To: Krzysztof Helt <krzysztof.h1@wp.pl>
Cc: hpa@zytor.com, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86: fdiv bug detection fix
Date: Thu, 31 Jul 2008 23:57:12 +0200 [thread overview]
Message-ID: <20080731215712.GC23801@elte.hu> (raw)
In-Reply-To: <20080731234344.eb3c4ed2.krzysztof.h1@wp.pl>
* Krzysztof Helt <krzysztof.h1@wp.pl> wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
>
> The fdiv detection code writes s32 integer into
> the boot_cpu_data.fdiv_bug.
> However, the boot_cpu_data.fdiv_bug is only char (s8)
> field so the detection overwrites already set fields for
> other bugs, e.g. the f00f bug field.
>
> Use local s32 variable to receive result.
applied to tip/x86/urgent, thanks Krzysztof!
this bug seems to be rather old - i guess new kernels rarely get tested
with those CPUs that are affected by those bugs?
Ingo
prev parent reply other threads:[~2008-07-31 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 21:43 [PATCH] x86: fdiv bug detection fix Krzysztof Helt
2008-07-31 21:49 ` Andrew Morton
2008-07-31 22:04 ` Jeremy Fitzhardinge
2008-07-31 22:11 ` Willy Tarreau
2008-07-31 21:57 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731215712.GC23801@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=krzysztof.h1@wp.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.