From: Andrew Morton <akpm@linux-foundation.org>
To: Simon Horman <horms@verge.net.au>
Cc: jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [patch for 2.6.27? 2/2] drivers/net/netxen/netxen_nic_hw.c: fix printk warnings
Date: Thu, 31 Jul 2008 23:28:09 -0700 [thread overview]
Message-ID: <20080731232809.470dd7d1.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080801061952.GI27241@verge.net.au>
On Fri, 1 Aug 2008 16:19:53 +1000 Simon Horman <horms@verge.net.au> wrote:
> On Wed, Jul 30, 2008 at 12:50:12PM -0700, akpm@linux-foundation.org wrote:
> > From: Andrew Morton <akpm@linux-foundation.org>
> >
> > drivers/net/netxen/netxen_nic_hw.c: In function 'netxen_nic_pci_mem_read_direct':
> > drivers/net/netxen/netxen_nic_hw.c:1414: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'
> > drivers/net/netxen/netxen_nic_hw.c: In function 'netxen_nic_pci_mem_write_direct':
> > drivers/net/netxen/netxen_nic_hw.c:1487: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'
> >
> > You don't know what type was used for u64 hence they cannot be printed without
> > casting.
>
> Good grief, that is a sledgehammer to crack an egg.
> Pity it is the only tool available :-(
The sad thing is that if/when we get around to converting all 64-bit
architectures to `long long', we then get to delete all these casts.
Oh well, at least they're easy to grep for.
I wonder who was the first 64-bit bright spark who decided to use `long'.
next prev parent reply other threads:[~2008-08-01 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 19:50 [patch for 2.6.27? 2/2] drivers/net/netxen/netxen_nic_hw.c: fix printk warnings akpm
2008-08-01 6:19 ` Simon Horman
2008-08-01 6:28 ` Andrew Morton [this message]
2008-08-01 6:55 ` David Miller
2008-08-01 7:01 ` Andrew Morton
2008-08-07 6:24 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731232809.470dd7d1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=horms@verge.net.au \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.