From: Peter Oruba <peter.oruba@amd.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Oruba <peter.oruba@amd.com>
Subject: [patch 2/2] [PATCH 2/2] x86: Fixed NULL function pointer dereference in AMD microcode patch loader.
Date: Fri, 1 Aug 2008 12:46:46 +0200 [thread overview]
Message-ID: <20080801104754.604840263@amd.com> (raw)
In-Reply-To: 20080801104644.788786464@amd.com
[-- Attachment #1: 0002-x86-Fixed-NULL-function-pointer-dereference-in-AMD.patch --]
[-- Type: text/plain, Size: 820 bytes --]
Dereference took place in code part responsible for manual installation
of microcode patches through /dev/cpu/microcode.
Signed-off-by: Peter Oruba <peter.oruba@amd.com>
---
arch/x86/kernel/microcode.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/microcode.c b/arch/x86/kernel/microcode.c
index 39961bb..ad136ad 100644
--- a/arch/x86/kernel/microcode.c
+++ b/arch/x86/kernel/microcode.c
@@ -127,7 +127,8 @@ static int do_microcode_update(void)
old = current->cpus_allowed;
while ((cursor = microcode_ops->get_next_ucode(&new_mc, cursor)) > 0) {
- error = microcode_ops->microcode_sanity_check(new_mc);
+ if (microcode_ops->microcode_sanity_check != NULL)
+ error = microcode_ops->microcode_sanity_check(new_mc);
if (error)
goto out;
/*
--
1.5.4.5
next prev parent reply other threads:[~2008-08-01 10:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 10:46 [patch 0/2] x86: microcode patch loader cleanup and fix Peter Oruba
2008-08-01 10:46 ` [patch 1/2] [PATCH 1/2] x86: Microcode patch loader style corrections Peter Oruba
2008-08-14 2:03 ` Andrew Morton
2008-08-01 10:46 ` Peter Oruba [this message]
2008-08-14 2:05 ` [patch 2/2] [PATCH 2/2] x86: Fixed NULL function pointer dereference in AMD microcode patch loader Andrew Morton
2008-08-14 11:55 ` Peter Oruba
2008-08-15 15:19 ` [patch 0/2] x86: microcode patch loader cleanup and fix Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080801104754.604840263@amd.com \
--to=peter.oruba@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tigran@aivazian.fsnet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.