From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KOuIF-00048T-KG for mharc-grub-devel@gnu.org; Fri, 01 Aug 2008 09:03:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOuIA-00047b-RI for grub-devel@gnu.org; Fri, 01 Aug 2008 09:03:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOuI8-00046r-FS for grub-devel@gnu.org; Fri, 01 Aug 2008 09:03:34 -0400 Received: from [199.232.76.173] (port=38930 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOuI5-00046g-Pa for grub-devel@gnu.org; Fri, 01 Aug 2008 09:03:30 -0400 Received: from aybabtu.com ([69.60.117.155]:55644) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KOuI5-0005c6-4G for grub-devel@gnu.org; Fri, 01 Aug 2008 09:03:29 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KOuBC-0007wp-NC for grub-devel@gnu.org; Fri, 01 Aug 2008 14:56:23 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KOuH0-0003JN-SX for grub-devel@gnu.org; Fri, 01 Aug 2008 15:02:22 +0200 Date: Fri, 1 Aug 2008 15:02:22 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080801130222.GA12405@thorin> References: <1217459965.26275.14.camel@fz-deb.local> <877ib1hvce.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877ib1hvce.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] skip over invalid BSD partitions X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2008 13:03:36 -0000 On Fri, Aug 01, 2008 at 12:40:17PM +0200, Marco Gerards wrote: > > - return grub_error (GRUB_ERR_BAD_PART_TABLE, > > - "no space for disk label"); > > - > > + { > > + grub_error (GRUB_ERR_BAD_PART_TABLE, > > + "no space for disk label"); > > + continue; > > + } > > If you continue as no error occured, why do you throw an error? Uhm nobody's going to handle this error. The caller will simply see that some partitions are not processed. How about using grub_dprintf instead? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."