From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KOupM-0008Ri-IT for mharc-grub-devel@gnu.org; Fri, 01 Aug 2008 09:37:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOupK-0008PL-K6 for grub-devel@gnu.org; Fri, 01 Aug 2008 09:37:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOupJ-0008Nd-I9 for grub-devel@gnu.org; Fri, 01 Aug 2008 09:37:49 -0400 Received: from [199.232.76.173] (port=38131 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOupJ-0008NS-Bu for grub-devel@gnu.org; Fri, 01 Aug 2008 09:37:49 -0400 Received: from aybabtu.com ([69.60.117.155]:55849) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KOupI-0004zQ-Vn for grub-devel@gnu.org; Fri, 01 Aug 2008 09:37:49 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KOuiQ-00085X-Ls for grub-devel@gnu.org; Fri, 01 Aug 2008 15:30:42 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KOuoK-0003lR-4o for grub-devel@gnu.org; Fri, 01 Aug 2008 15:36:48 +0200 Date: Fri, 1 Aug 2008 15:36:48 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080801133648.GA14359@thorin> References: <1217286307.4016.107.camel@fz-deb.local> <20080730103708.GA17771@thorin> <1217417950.6234.6.camel@fz-deb.local> <1217430684.6234.14.camel@fz-deb.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1217430684.6234.14.camel@fz-deb.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] show an error instead of segfaulting on grub-probe -t partmap on a unsynced raid X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2008 13:37:51 -0000 On Wed, Jul 30, 2008 at 05:11:24PM +0200, Felix Zielcke wrote: > Index: disk/raid.c > =================================================================== > --- disk/raid.c (Revision 1753) > +++ disk/raid.c (Arbeitskopie) > @@ -75,8 +75,10 @@ > grub_disk_memberlist_t list = NULL, tmp; > unsigned int i; > > - for (i = 0; i < array->total_devs; i++) > + for (i = 0; i < GRUB_RAID_MAX_DEVICES; i++) The existing code is confusing. What is total_devs for? If we need to iterate up to 32, sounds like this variable is pointless? If it's useless, it should be removed (but maybe it isn't!). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."