Re: [PATCH 13/21] implement generic xfs_btree_update

[Christoph Hellwig <hch@lst.de>]

On Wed, Jul 30, 2008 at 03:29:59PM +1000, Dave Chinner wrote:
> Oh, it's be moved inside the update code itself. So, why always call
> the update function and then check the ptr? Why not the way it was
> originally done?

Because all three callers do different checks, and I could not proof
that they are either identical or hamrless for the other cases.
We can clean this mess up later in small standalone patches.

> > +	/* updated last record information */
> > +	void	(*update_lastrec)(struct xfs_btree_cur *,
> > +				  struct xfs_btree_block *,
> > +				  union xfs_btree_rec *, int, int);
> 
> Can you add the variable names to the prototype parameters?

Done.