From: Christoph Hellwig <hch@lst.de>
To: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 21/21] clean up xfs_bmap_btree.c
Date: Fri, 1 Aug 2008 21:55:56 +0200 [thread overview]
Message-ID: <20080801195556.GL1263@lst.de> (raw)
In-Reply-To: <20080730073245.GV13395@disturbed>
On Wed, Jul 30, 2008 at 05:32:45PM +1000, Dave Chinner wrote:
> > + ASSERT(nrecs == crecs);
> > + kp = xfs_bmbt_key_addr(cur, 1, block);
> > + ckp = xfs_bmbt_key_addr(cur, 1, cblock);
> > + memcpy(kp, ckp, nrecs * sizeof(xfs_bmbt_key_t));
>
> Should really be xfs_bmbt_copy_keys(), right?
Yes, fixed.
> > + memcpy(pp, cpp, nrecs * sizeof(xfs_bmbt_key_t));
>
> xfs_bmbt_copy_recs()?
Yes, fixed.
prev parent reply other threads:[~2008-08-01 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 19:32 [PATCH 21/21] clean up xfs_bmap_btree.c Christoph Hellwig
2008-07-30 7:32 ` Dave Chinner
2008-08-01 19:55 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080801195556.GL1263@lst.de \
--to=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.