From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] Re: distclean failure
Date: Fri, 1 Aug 2008 21:42:45 +0100 [thread overview]
Message-ID: <20080801204245.GC4526@implementation> (raw)
In-Reply-To: <489374BF.4010802@goop.org>
Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:40:31 -0700, a écrit :
> Samuel Thibault wrote:
> >Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a écrit :
> >
> >>>+ [ ! -d libxc ] || $(MAKE) -C libxc clean
> >>>+ [ ! -d ioemu ] || $(MAKE) -C ioemu clean
> >>>
> >>Are you sure you don't not need a double negative there?
> >>
> >
> >Mmm, why? The clean target succeeds if either there is not even
> >libxc/ioemu directories, or the make clean there works.
> >
>
> I'm just pointing out that
>
> [ -d libxc ] && $(MAKE) -C libxc clean
>
> is more straightforward.
But it makes the rule fail if the directory doesn't exist.
Samuel
next prev parent reply other threads:[~2008-08-01 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 14:14 distclean failure Christoph Egger
2008-08-01 14:18 ` [PATCH] " Samuel Thibault
2008-08-01 14:26 ` Christoph Egger
2008-08-01 14:36 ` Christoph Egger
2008-08-01 14:38 ` Keir Fraser
2008-08-01 20:27 ` Jeremy Fitzhardinge
2008-08-01 20:36 ` Samuel Thibault
2008-08-01 20:40 ` Jeremy Fitzhardinge
2008-08-01 20:42 ` Samuel Thibault [this message]
2008-08-01 20:55 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080801204245.GC4526@implementation \
--to=samuel.thibault@eu.citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.