From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 11/21] implement generic xfs_btree_lookup
Date: Sat, 2 Aug 2008 11:14:00 +1000 [thread overview]
Message-ID: <20080802011400.GK6201@disturbed> (raw)
In-Reply-To: <20080801194336.GE1263@lst.de>
On Fri, Aug 01, 2008 at 09:43:36PM +0200, Christoph Hellwig wrote:
> On Wed, Jul 30, 2008 at 02:59:37PM +1000, Dave Chinner wrote:
> > > --- linux-2.6-xfs.orig/fs/xfs/xfs_alloc.c 2008-07-15 17:46:52.000000000 +0200
> > > +++ linux-2.6-xfs/fs/xfs/xfs_alloc.c 2008-07-15 17:51:41.000000000 +0200
> > > @@ -90,6 +90,54 @@ STATIC int xfs_alloc_ag_vextent_small(xf
> > > */
> > >
> > > /*
> > > + * Lookup the record equal to [bno, len] in the btree given by cur.
> > > + */
> > > +STATIC int /* error */
> > > +xfs_alloc_lookup_eq(
> >
> > Should these be xfs_allocbt_lookup_*() to be consistent
> > with all the other allocbt functions (and inobt_lookup/bmbt_lookup)?
>
> Currently only the btree_ops methods are named allocbt. Comments on
> that scheme would be appreciated.
I think I used 'abt' for it. Perhaps 'albt'? allocbt is probably ok,
though, just longer.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2008-08-02 1:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 19:31 [PATCH 11/21] implement generic xfs_btree_lookup Christoph Hellwig
2008-07-30 4:59 ` Dave Chinner
2008-08-01 19:43 ` Christoph Hellwig
2008-08-02 1:14 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080802011400.GK6201@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.