From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 12/21] implement generic xfs_btree_updkey
Date: Sat, 2 Aug 2008 11:14:42 +1000 [thread overview]
Message-ID: <20080802011442.GL6201@disturbed> (raw)
In-Reply-To: <20080801194452.GF1263@lst.de>
On Fri, Aug 01, 2008 at 09:44:52PM +0200, Christoph Hellwig wrote:
> On Wed, Jul 30, 2008 at 03:09:36PM +1000, Dave Chinner wrote:
> > And even then I think we might not need an error variable - it can
> > only return EFSCORRUPTED, so:
> >
> > #ifdef DEBUG
> > if (xfs_btree_check_block(cur, block, level, bp)) {
> > XFS_BTREE_TRACE_CURSOR(cur, XBT_ERROR);
> > return EFSCORRUPTED;
> > }
> > #endif
> >
> > Would remove the need for the error variable.
>
> I'm not a big fan of losing detailed error information. Depending
> on how the bigger btree blocks work out we might return other errors
> here in the near future.
Fair enough.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2008-08-02 1:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 19:31 [PATCH 12/21] implement generic xfs_btree_updkey Christoph Hellwig
2008-07-30 5:09 ` Dave Chinner
2008-08-01 19:44 ` Christoph Hellwig
2008-08-02 1:14 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080802011442.GL6201@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.