From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KPFdb-0004MZ-3I for mharc-grub-devel@gnu.org; Sat, 02 Aug 2008 07:51:07 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KPFdZ-0004JX-69 for grub-devel@gnu.org; Sat, 02 Aug 2008 07:51:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KPFdY-0004I9-9i for grub-devel@gnu.org; Sat, 02 Aug 2008 07:51:04 -0400 Received: from [199.232.76.173] (port=51207 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPFdY-0004Hr-4r for grub-devel@gnu.org; Sat, 02 Aug 2008 07:51:04 -0400 Received: from aybabtu.com ([69.60.117.155]:37857) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KPFdX-0003vb-Pm for grub-devel@gnu.org; Sat, 02 Aug 2008 07:51:03 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KPFWX-00035w-46 for grub-devel@gnu.org; Sat, 02 Aug 2008 13:43:49 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KPFcV-0004CD-7M for grub-devel@gnu.org; Sat, 02 Aug 2008 13:49:59 +0200 Date: Sat, 2 Aug 2008 13:49:59 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080802114959.GA16063@thorin> References: <20080802104828.GA11358@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] PXE support for grub2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Aug 2008 11:51:05 -0000 On Sat, Aug 02, 2008 at 07:20:31PM +0800, Bean wrote: > >> --- a/kern/i386/pc/startup.S > >> +++ b/kern/i386/pc/startup.S > >> @@ -2053,3 +2053,102 @@ FUNCTION(grub_vbe_bios_set_palette_data) > >> popl %ebx > >> popl %ebp > >> ret > >> + > >> + > >> +pxe_rm_entry: > >> + .long 0 > >> + > >> +/* > >> + * struct grub_pxenv *grub_pxe_scan (void); > >> + */ > >> +FUNCTION(grub_pxe_scan) > > > > Could these go in a module? If they're only used by disk/i386/pc/pxe.c, > > maybe they could be merged with that? > > The problem is that they need to call real mode function provided by > the pxe rom, so this code must be loaded under 1m. We can solve this > with real mode stub or the patch suggested by daChaac, but it's not > there yet. So we need to keep it in startup.S for some time. Well I guess we can live with that for a while... -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."