From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KPwC1-0006rJ-Vb for mharc-grub-devel@gnu.org; Mon, 04 Aug 2008 05:17:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KPwBz-0006qH-Pt for grub-devel@gnu.org; Mon, 04 Aug 2008 05:17:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KPwBx-0006pC-2c for grub-devel@gnu.org; Mon, 04 Aug 2008 05:17:27 -0400 Received: from [199.232.76.173] (port=54899 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPwBw-0006p4-Q8 for grub-devel@gnu.org; Mon, 04 Aug 2008 05:17:24 -0400 Received: from aybabtu.com ([69.60.117.155]:43102) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KPwBw-00061A-5O for grub-devel@gnu.org; Mon, 04 Aug 2008 05:17:24 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KPw4k-0005Kr-Da for grub-devel@gnu.org; Mon, 04 Aug 2008 11:09:58 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KPwAt-0000F1-3v for grub-devel@gnu.org; Mon, 04 Aug 2008 11:16:19 +0200 Date: Mon, 4 Aug 2008 11:16:19 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080804091619.GA737@thorin> References: <1217809888.6283.27.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1217809888.6283.27.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Current SVN is broken on x86_64 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Aug 2008 09:17:28 -0000 On Mon, Aug 04, 2008 at 02:31:28AM +0200, Felix Zielcke wrote: > I just tried to compile the Debian packages with the currently SVN > version and it failed: > > cc -Iloader/i386/efi -I/home/fz/grub/grub2-1.96+20080804/loader/i386/efi -I. -Iinclude -I/home/fz/grub/grub2-1.96+20080804/include -Wall -W -Wall -W -Wshadow -Wpointer-arith -Wmissing-prototypes -Wundef -Wstrict-prototypes -g -Os -m64 -fno-stack-protector -mno-stack-arg-probe -fno-builtin -m64 -MD -c -o _linux_mod-loader_i386_efi_linux.o /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c > In file included from /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c:34: > /home/fz/grub/grub2-1.96+20080804/include/grub/pci.h:48:26: error: grub/cpu/pci.h: No such file or directory > /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c: In function 'grub_find_video_card': > /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c:471: warning: implicit declaration of function 'grub_pci_read' So we have grub/i386/pci.h but not grub/x86_64/pci.h. This is my fault, but I think it's too easy to make mistakes with this vs duplicity. Furthermore, I had a look and some of the x86_64 versions are just stubs that include the i386 one. Why don't we handle this like Linux? They ship a single directory and use #ifdefs where appropiate. That enforces consistency in the dir layout. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."